1165395 - Cache API should test re-initializing QM after use

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Recently I messed up the QuotaManager storage directories in the Cache code.  This only showed on the next time QM initialized.  We should have a test case to catch this kind of thing.

See bug 1164100 for the kind of fallout that can occur.

Ben indicates there's a QM.reset() function or something that can be called from a mochitest.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Test Cache API after QuotaManager reset. r=janv

I ran this test against an old m-c prior to bug 1164100 landing.  It correctly fails when the morgue directory is created.

Note, I had to pipe QuotaManager.reset() through to SpecialPowers.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7054968c36b

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Backed out for B2G crashes.
https://treeherder.mozilla.org/logviewer.html#?job_id=9968193&repo=mozilla-inbound

Comment 4

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce1ae7b61a30

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Attachment: interdiff 001 address treeherder b2g failures

Actually, I think this is problem from bug 1162365.  We just didn't catch it before without this test.  I think this interdiff should fix it.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2735bba4ea77

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Test Cache API after QuotaManager reset. r=janv

Try shows that the b2g emulator no longer fails with the additional fix.  I'll land as soon as the trees re-open.

Comment 7

[Jan Varga [:janv]]

Comment on attachment 8607710 [details] [diff] [review]
Test Cache API after QuotaManager reset. r=janv

Review of attachment 8607710 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the !aUsageInfo check

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

Thanks!  Sorry I didn't reflag.  I thought it was small enough and clearly correct I could just put it in with the previous patch.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eda5deaf71b9

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eda5deaf71b9