Closed Bug 1165422 Opened 4 years ago Closed 4 years ago

Update Android SDK and build tools to 22

Categories

(Infrastructure & Operations :: CIDuty, task)

task
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Tracking Status
firefox41 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

()

Details

Attachments

(4 files, 2 obsolete files)

Looking at the patch in bug 1084494 for precedent, I'm not sure what the digest is - Wes, do you know what's going on there?
Flags: needinfo?(wjohnston)
bug 1084498 is the one you mean, but when you upload the sdk to tool-tool. the digest will be printed out for you.
Depends on: 1084498
No longer depends on: 1084494
Flags: needinfo?(wjohnston)
Seems I don't have the proper auth bits in order to get an upload authentication token for tooltool. :(

Wes, can you tell me where to get them?
Flags: needinfo?(wjohnston)
I leave this entirely up to Wes, 'cos I have no clue :)

But do remember to bump the minimum a la Bug 1024238 after getting the builders updated if this is a required change for all developers.
(In reply to Michael Comella (:mcomella) from comment #4)
> Seems I don't have the proper auth bits in order to get an upload
> authentication token for tooltool. :(
> 
> Wes, can you tell me where to get them?

File a ticket, like Bug 1039994 or Bug 1090606.
Flags: needinfo?(wjohnston)
Assignee: nobody → michael.l.comella
/r/9501 - Bug 1165422 - Update to Android SDK to v22 (5.1). r=coop
/r/9503 - Bug 1165422 - Touch CLOBBER after updating Android build tools. r=me

Pull down these commits:

hg pull -r d45b46410db680090fe0efef00353181e1a99e9a https://reviewboard-hg.mozilla.org/gecko/
Attachment #8611534 - Flags: review?(coop)
try in comment 9 is almost green so I opened a review on comment 10.
Attachment #8611534 - Flags: review?(coop) → review+
Reviewboard refused to mark the review as r+, so I've manually flagged it. :/
mcomella: we have some small updates to do before landing this:

* bump Gradle versions; (just rev various 21 bits to 22 in mobile/android/gradle/**/build.gradle;
* update mozboot (|mach bootstrap| versions);  (This should close Bug 1162000.)
* IIRC somewhere in android.m4 or mobile/android/config there's a version code that needs to be updated.
Blocks: 1162000
mcomella: if you can try the above in https://bugzilla.mozilla.org/show_bug.cgi?id=1165422#c18 I'd appreciate it.  If not, we can file a follow-up and get to it when we can.
Flags: needinfo?(michael.l.comella)
(In reply to Nick Alexander :nalexander from comment #18)
> * IIRC somewhere in android.m4 or mobile/android/config there's a version
> code that needs to be updated.

I found [1] but that doesn't seem to need to be updated and I updated mozconfigs/common in mobile/android/config.

[1]: https://mxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4#320
Let's just go all the way and update to the M stuff (bug 1169421) to avoid any weird backwards-compat issues when devs upgrade - I'm going to need new patches.
Depends on: 1169421
Flags: needinfo?(michael.l.comella)
Bug 1165422 - Update gradle build tools versions to 22.0.1. r?nalexander
Attachment #8615447 - Flags: review?(nalexander)
Bug 1165422 - Bump mach bootstrap versions for SDK 22. r?nalexander
Attachment #8615448 - Flags: review?(nalexander)
Comment on attachment 8615447 [details]
MozReview Request: Bug 1165422 - Update gradle build tools versions to 22.0.1. r?nalexander

https://reviewboard.mozilla.org/r/9501/#review8999

Ship It!
Attachment #8615447 - Flags: review?(nalexander) → review+
Attachment #8615448 - Flags: review?(nalexander) → review+
Comment on attachment 8615448 [details]
MozReview Request: Bug 1165422 - Bump mach bootstrap versions for SDK 22. r?nalexander

https://reviewboard.mozilla.org/r/9503/#review9001

Ship It!
(In reply to Nick Alexander :nalexander from comment #18)
> mcomella: we have some small updates to do before landing this:
> 
> * bump Gradle versions; (just rev various 21 bits to 22 in
> mobile/android/gradle/**/build.gradle;
> * update mozboot (|mach bootstrap| versions);  (This should close Bug
> 1162000.)
> * IIRC somewhere in android.m4 or mobile/android/config there's a version
> code that needs to be updated.

This version is at https://dxr.mozilla.org/mozilla-central/source/mobile/android/config/mozconfigs/common#22.
Attachment #8611534 - Attachment is obsolete: true
I wrote a wiki page on how to do this for future reference: https://wiki.mozilla.org/Mobile/Fennec/Android/Updating_SDK_on_builders

(Thanks Nick for the idea!)
No longer depends on: 1169421
I used the wrong version of the Android support library (hence the failure in comment 29).

The versions that should be installed are:
* Tools r24.3
* Platform-tools r22
* Build-tools r22.0.1
* Google play services r25
* Platform 22 (non-preview)
* Support library r22.2 (I had r19.1 installed)
Comment on attachment 8615556 [details]
MozReview Request: Bug 1165422 - Update builder configurations to android API 22. r?coop

https://reviewboard.mozilla.org/r/10287/#review9031

Ship It!
Attachment #8615556 - Flags: review?(coop) → review+
Attachment #8615556 - Flags: review+ → review?(coop)
Comment on attachment 8615556 [details]
MozReview Request: Bug 1165422 - Update builder configurations to android API 22. r?coop

Bug 1165422 - Update builder configurations to android API 22. r?coop
Comment on attachment 8615556 [details]
MozReview Request: Bug 1165422 - Update builder configurations to android API 22. r?coop

They're just hashes so I'm assuming these coop won't mind not reviewing each revision. :)
Attachment #8615556 - Flags: review?(coop) → review+
Attached patch Upgrade gradle targetSdk to 22 (obsolete) — Splinter Review
Forgot to land this as part of the original changes - this should allow
successful compiling in Intellij.
Forgot to land this as part of the original, and next, changes.
Attachment #8616303 - Attachment is obsolete: true
Comment on attachment 8615556 [details]
MozReview Request: Bug 1165422 - Update builder configurations to android API 22. r?coop

https://reviewboard.mozilla.org/r/10287/#review9387

Ship It!
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
You need to log in before you can comment on or make changes to this bug.