Restore support for binary components in extensions on a per-application basis

RESOLVED FIXED in Firefox 40

Status

()

Core
XPCOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

unspecified
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed, firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
bug 1159737 removed support for binary extensions, we'd like to have this restored for Thunderbird at least.
(Assignee)

Comment 1

3 years ago
Created attachment 8606429 [details] [diff] [review]
Fix - v1

How is this? I tested this patch locally and it seems to work for me, but I am not sure if its the right way to go. The other alternative would be to switch NS_EXTENSION_LOCATION / NS_APP_LOCATION based on that confvar, but then it would have to be kept up to date in more than one location.
Attachment #8606429 - Flags: review?(benjamin)
(Assignee)

Updated

3 years ago
Summary: Restore support for binary components on a per-application basis → Restore support for binary components in extensions on a per-application basis
(Assignee)

Updated

3 years ago
Blocks: 1163306

Comment 2

3 years ago
Comment on attachment 8606429 [details] [diff] [review]
Fix - v1

I suggest rather than the AC_SUBST, just do:

if test -n "$MOZ_BINARY_EXTENSIONS"; then
  AC_DEFINE(MOZ_BINARY_EXTENSIONS);
fi

And then you don't need the moz.build change.

The rest looks fine. r=me with that change or please ping me if that doesn't work or you're not sure what I mean.
Attachment #8606429 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8608240 [details] [diff] [review]
Fix - v2
Attachment #8606429 - Attachment is obsolete: true
Attachment #8608240 - Flags: review+
(Assignee)

Updated

3 years ago
Blocks: 1166842

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/08084ee427ec
https://hg.mozilla.org/mozilla-central/rev/08084ee427ec
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41

Updated

3 years ago
status-firefox40: --- → affected
(Assignee)

Comment 6

3 years ago
Comment on attachment 8608240 [details] [diff] [review]
Fix - v2

Approval Request Comment
[Feature/regressing bug #]: bug 1159737
[User impact if declined]: Non-Firefox apps cannot enable binary extensions
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low risk, code remains enabled via preprocessor in Firefox
[String/UUID change made/needed]: none
Attachment #8608240 - Flags: approval-mozilla-aurora?
Attachment #8608240 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/70c2ff2c692d
status-firefox40: affected → fixed
You need to log in before you can comment on or make changes to this bug.