Closed Bug 1165428 Opened 5 years ago Closed 5 years ago
Restore support for binary components in extensions on a per-application basis
bug 1159737 removed support for binary extensions, we'd like to have this restored for Thunderbird at least.
How is this? I tested this patch locally and it seems to work for me, but I am not sure if its the right way to go. The other alternative would be to switch NS_EXTENSION_LOCATION / NS_APP_LOCATION based on that confvar, but then it would have to be kept up to date in more than one location.
Attachment #8606429 - Flags: review?(benjamin)
Summary: Restore support for binary components on a per-application basis → Restore support for binary components in extensions on a per-application basis
Comment on attachment 8606429 [details] [diff] [review] Fix - v1 I suggest rather than the AC_SUBST, just do: if test -n "$MOZ_BINARY_EXTENSIONS"; then AC_DEFINE(MOZ_BINARY_EXTENSIONS); fi And then you don't need the moz.build change. The rest looks fine. r=me with that change or please ping me if that doesn't work or you're not sure what I mean.
Attachment #8606429 - Flags: review?(benjamin) → review+
Comment on attachment 8608240 [details] [diff] [review] Fix - v2 Approval Request Comment [Feature/regressing bug #]: bug 1159737 [User impact if declined]: Non-Firefox apps cannot enable binary extensions [Describe test coverage new/current, TreeHerder]: [Risks and why]: Low risk, code remains enabled via preprocessor in Firefox [String/UUID change made/needed]: none
Attachment #8608240 - Flags: approval-mozilla-aurora?
Attachment #8608240 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.