Closed
Bug 1165458
Opened 7 years ago
Closed 6 years ago
Intermittent VsyncTester.CompositorGetVsyncNotifications | Value of: testVsyncObserver->DidGetVsyncNotification()
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: RyanVM, Assigned: mchang)
Details
(Keywords: intermittent-failure, Whiteboard: gfx-noted)
Attachments
(1 file)
820 bytes,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
12:33:17 INFO - TEST-START | VsyncTester.CompositorGetVsyncNotifications 12:33:17 WARNING - TEST-UNEXPECTED-FAIL | VsyncTester.CompositorGetVsyncNotifications | Value of: testVsyncObserver->DidGetVsyncNotification() 12:33:17 INFO - Actual: false 12:33:17 INFO - Expected: true @ c:\builds\moz2_slave\m-in-w64-d-0000000000000000000\build\src\gfx\tests\gtest\TestVsync.cpp:151 12:33:17 WARNING - TEST-UNEXPECTED-FAIL | VsyncTester.CompositorGetVsyncNotifications | test completed (time: 54ms)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 6•7 years ago
|
||
This has been in the tree for quite some time and popped up twice then disappeared again. Still waiting to see if this is a really big problem. If the VMs are just really slow for some reason, this could be causing the delay.
Flags: needinfo?(mchang)
Reporter | ||
Comment 7•7 years ago
|
||
The failures have been on real slaves, fwiw (not VMs).
Comment 8•7 years ago
|
||
Inactive; closing (see bug 1180138).
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•7 years ago
|
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mchang
Assignee | ||
Comment 13•6 years ago
|
||
Raise the timeout from 50ms to 80 ms, which is 5 vsync intervals. This intermittent seems to mostly happen on Windows 8-64, which is a weird platform. I can only imagine that the system is too busy or we're getting super long wake ups from DwmFlush().
Attachment #8709680 -
Flags: review?(bugmail.mozilla)
Updated•6 years ago
|
Attachment #8709680 -
Flags: review?(bugmail.mozilla) → review+
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b8dfc7fb1398
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•