Inline push/pop/shift on unboxed arrays in Ion

RESOLVED FIXED in Firefox 41

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

(Blocks: 1 bug)

Trunk
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8606497 [details] [diff] [review]
patch

This is pretty straightforward.
Attachment #8606497 - Flags: review?(jdemooij)
(Assignee)

Comment 1

3 years ago
Created attachment 8606651 [details] [diff] [review]
patch

Remove an extraneous modification to the octane source.
Assignee: nobody → bhackett1024
Attachment #8606497 - Attachment is obsolete: true
Attachment #8606497 - Flags: review?(jdemooij)
Attachment #8606651 - Flags: review?(jdemooij)
Comment on attachment 8606651 [details] [diff] [review]
patch

Review of attachment 8606651 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/IonBuilder.cpp
@@ +5207,5 @@
>      JSFunction* target = &targetArg->as<JSFunction>();
>      if (target->isNative()) {
>          InliningStatus status = inlineNativeCall(callInfo, target);
> +        if (status == InliningStatus_NotInlined)
> +            status = inlineNativeCall(callInfo, target);

What's the point of this?
(Assignee)

Comment 3

3 years ago
(In reply to Jan de Mooij [:jandem] from comment #2)
> Comment on attachment 8606651 [details] [diff] [review]
> patch
> 
> Review of attachment 8606651 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/IonBuilder.cpp
> @@ +5207,5 @@
> >      JSFunction* target = &targetArg->as<JSFunction>();
> >      if (target->isNative()) {
> >          InliningStatus status = inlineNativeCall(callInfo, target);
> > +        if (status == InliningStatus_NotInlined)
> > +            status = inlineNativeCall(callInfo, target);
> 
> What's the point of this?

Oops, this was in place for debugging.
Comment on attachment 8606651 [details] [diff] [review]
patch

Review of attachment 8606651 [details] [diff] [review]:
-----------------------------------------------------------------

OK, r=me with the debugging code removed.
Attachment #8606651 - Flags: review?(jdemooij) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/57dce88fc620

Comment 6

3 years ago
https://hg.mozilla.org/mozilla-central/rev/57dce88fc620
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Depends on: 1190002
Depends on: 1190147
Depends on: 1190272
No longer depends on: 1190272
You need to log in before you can comment on or make changes to this bug.