Closed
Bug 1165504
Opened 9 years ago
Closed 9 years ago
Clean up marker details
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox40 fixed, firefox41 fixed)
RESOLVED
FIXED
Firefox 41
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
26.17 KB,
patch
|
vporof
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Make this more declaritive, easier to extend.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
This will make adding custom detail views, and easily change labels for anyone doing marker things.
Attachment #8606544 -
Flags: review?(vporof)
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e35b7830cb3
Comment 3•9 years ago
|
||
Comment on attachment 8606544 [details] [diff] [review] 1165504-refactor-markers.patch Review of attachment 8606544 [details] [diff] [review]: ----------------------------------------------------------------- oh my god i love this patch so much ::: browser/devtools/performance/modules/recording-utils.js @@ +208,5 @@ > * @return object > * The filtered timeline blueprint. > */ > exports.RecordingUtils.getFilteredBlueprint = function({ blueprint, hiddenMarkers }) { > + // Clone functions here just to prevent an error; we don't need them here. A bit more details about the error por favor. ::: browser/devtools/shared/timeline/global.js @@ +20,5 @@ > * - group: the row index in the timeline overview graph; multiple markers > * can be added on the same row. @see <overview.js/buildGraphImage> > + * - label: the label used in the waterfall to identify the marker. Can be a > + * string or just a function that accepts the marker and returns a string, > + * if you want to use a dynamic property for the main label. Need one more space of indentation here for the last two lines. @@ +101,3 @@ > }, > + > + /* Group 2 - User Controlled? */ No "?"
Attachment #8606544 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Addressed comments, landed: https://hg.mozilla.org/integration/fx-team/rev/39b771cd88ec
Whiteboard: [fixed-in-fx-team]
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/39b771cd88ec
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
Blocks: perf-40-uplifts
Updated•9 years ago
|
Flags: qe-verify-
Comment 6•9 years ago
|
||
Comment on attachment 8606544 [details] [diff] [review] 1165504-refactor-markers.patch Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8606544 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d088567ac313
status-firefox40:
--- → fixed
Comment 8•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 9•9 years ago
|
||
Comment on attachment 8606544 [details] [diff] [review] 1165504-refactor-markers.patch Change approved to skip one train as part of the spring campaign.
Attachment #8606544 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•