Clean up marker details

RESOLVED FIXED in Firefox 40

Status

RESOLVED FIXED
4 years ago
5 months ago

People

(Reporter: jsantell, Assigned: jsantell)

Tracking

(Blocks: 1 bug)

41 Branch
Firefox 41
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox40 fixed, firefox41 fixed)

Details

Attachments

(1 attachment)

Make this more declaritive, easier to extend.
(Assignee)

Updated

4 years ago
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Created attachment 8606544 [details] [diff] [review]
1165504-refactor-markers.patch

This will make adding custom detail views, and easily change labels for anyone doing marker things.
Attachment #8606544 - Flags: review?(vporof)
(Assignee)

Updated

4 years ago
Blocks: 1165425
(Assignee)

Updated

4 years ago
Blocks: 1162662
(Assignee)

Updated

4 years ago
No longer blocks: 1162662
(Assignee)

Updated

4 years ago
Blocks: 1162662
(Assignee)

Updated

4 years ago
Blocks: 1166005
(Assignee)

Updated

4 years ago
Blocks: 1153704
Comment on attachment 8606544 [details] [diff] [review]
1165504-refactor-markers.patch

Review of attachment 8606544 [details] [diff] [review]:
-----------------------------------------------------------------

oh my god i love this patch so much

::: browser/devtools/performance/modules/recording-utils.js
@@ +208,5 @@
>   * @return object
>   *         The filtered timeline blueprint.
>   */
>  exports.RecordingUtils.getFilteredBlueprint = function({ blueprint, hiddenMarkers }) {
> +  // Clone functions here just to prevent an error; we don't need them here.

A bit more details about the error por favor.

::: browser/devtools/shared/timeline/global.js
@@ +20,5 @@
>   *   - group: the row index in the timeline overview graph; multiple markers
>   *            can be added on the same row. @see <overview.js/buildGraphImage>
> + *   - label: the label used in the waterfall to identify the marker. Can be a
> + *           string or just a function that accepts the marker and returns a string,
> + *           if you want to use a dynamic property for the main label.

Need one more space of indentation here for the last two lines.

@@ +101,3 @@
>    },
> +
> +  /* Group 2 - User Controlled? */

No "?"
Attachment #8606544 - Flags: review?(vporof) → review+
Addressed comments, landed: https://hg.mozilla.org/integration/fx-team/rev/39b771cd88ec
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/39b771cd88ec
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Blocks: 1167252
Flags: qe-verify-
Comment on attachment 8606544 [details] [diff] [review]
1165504-refactor-markers.patch


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None
Attachment #8606544 - Flags: approval-mozilla-aurora?
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment on attachment 8606544 [details] [diff] [review]
1165504-refactor-markers.patch

Change approved to skip one train as part of the spring campaign.
Attachment #8606544 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.