Closed
Bug 1165514
Opened 9 years ago
Closed 9 years ago
[gh-pages] on http://mozilla.github.io/mozregression/ , show the number of gui releases downloaded
Categories
(Testing :: mozregression, defect)
Testing
mozregression
Tracking
(firefox41 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox41 | --- | affected |
People
(Reporter: parkouss, Assigned: joridoss, Mentored)
Details
(Whiteboard: [good first bug][lang=js])
Attachments
(2 files)
It would be good to show the number of releases downloaded for each os (Linux64 and Windows for now) in the main page of the mozregression web site: http://mozilla.github.io/mozregression/. This way we will have an easy way to see the actual number of downloads for the tool! To do that, we can query the github api: https://api.github.com/repos/mozilla/mozregression/releases. I suggest that we simply sum the numbers of downloaded release, for each os. Some knowledge of html, javascript and jekyll is required here, though I can help if needed. :) The code lives on the gh-pages branch of mozregression, and the README can help to set up things. After that, doing the same thing to count downloads on pypi could be interesting too - maybe just show a badge, or query pypi in the same way. This can be done in another bug.
Hi~ I would like to work on this bug if it's ok :) I have html and javascript but little about jekyll. However I can learn how to use it(it seems like a tools make your website can get data from github). This issue looks like need I get the "download_count" of each os (.exe and .zip or .tar) from this page (https://api.github.com/repos/mozilla/mozregression/releases)and reflect it on mozregression web site.
Reporter | ||
Comment 2•9 years ago
|
||
Yup, you're welcome to work on this! What you said is right, this is what I would like to do here. So you have to checkout the gh-pages branch of mozregression, then just follow this to get started: https://github.com/mozilla/mozregression/blob/gh-pages/README.md After that, try to understand how that work by looking at the jekyll documentation: http://jekyllrb.com/ And ask me if you need to! @wlach Do you like the idea here ? And do you have another idea to where to put the download count information ?
Assignee: nobody → sabergeass
Flags: needinfo?(wlachance)
Reporter | ||
Comment 4•9 years ago
|
||
Hm MikeLing I'm not sure I understoog well here. Are you still working on this bug ? Else I will unassign you, so somebody else can look at this.
Flags: needinfo?(sabergeass)
Reporter | ||
Comment 5•9 years ago
|
||
MikeLing is working on other stuff for now, so let's see if someone else may be interested to work on this bug.
Assignee: sabergeass → nobody
Flags: needinfo?(sabergeass)
Reporter | ||
Comment 7•9 years ago
|
||
Thanks joridoss this looks good ! (https://github.com/mozilla/mozregression/pull/231) There are some minor changes I would like to see. Instead of: > Downloads: > > gui-0.2 > linux: 4 > windows: 31 > > gui-pre-release > linux: 2 > windows: 5 Would it be possible to see: > Number of downloads for the gui version: > > linux: 6 > windows: 36 I don't think we need the details for each release (at least for a first look at the page, you could add a link "details" for example that could expand to detailed information for each release if you're interested!). Also I would prefer to put this block at the end of the page (after the "Recent news section"), so the page layout won't change much once the data is loaded. Last thing, when submitting patches for mozregression you should ask for a review here in bugzilla (see https://wiki.mozilla.org/Auto-tools/Projects/Mozregression#Submitting_patches). You have to do this by adding an attachment on this bug, put the url of the github PR in the main field (see https://globau.wordpress.com/2013/10/21/github-pull-requests-and-bugzilla/), choose "?" in the review flag and put my email address to choose me as a reviewer. Thanks again for tackling this bug! Please ask if you have any question. :)
Assignee: nobody → joridoss
Status: NEW → ASSIGNED
Reporter | ||
Comment 9•9 years ago
|
||
joridoss, are you still interested/do you have time to work on this ?
Flags: needinfo?(joridoss)
Assignee | ||
Comment 10•9 years ago
|
||
This and the next month I have a lot of things to do in my Job, so, anyone could clone my branch and make the changes
Flags: needinfo?(joridoss)
Reporter | ||
Comment 11•9 years ago
|
||
(In reply to joridoss from comment #10) > This and the next month I have a lot of things to do in my Job, so, anyone > could clone my branch and make the changes Right, thanks for the quick reply! And also for the work, we're almost done thanks to you. :)
Assignee: joridoss → nobody
Status: ASSIGNED → NEW
Comment 12•9 years ago
|
||
Attachment #8637682 -
Flags: review?(j.parkouss)
Comment 13•9 years ago
|
||
Hi Julien, I submitted a patch based on joridoss PR, but I made it a bit easier. Let me not if is good to land or needs something else. Thanks
Reporter | ||
Comment 14•9 years ago
|
||
Comment on attachment 8637682 [details] [review] Github PR Hey Giovanny, thanks! This is good, the main thing is that I would like a total of the downloads by platform (not specific to one release). I thought I said that in comment 7, but it is not obvious at all! Sorry for that. :) I noted some comment on the PR. Removing the review flag for now, please set it back when you're done.
Attachment #8637682 -
Flags: review?(j.parkouss)
Updated•9 years ago
|
Assignee: nobody → gioyik
Reporter | ||
Comment 15•9 years ago
|
||
Givanny, do you still want to work on this bug ? Else I'm going to reset the assignee, see if someone wants to take care of it.
Flags: needinfo?(gioyik)
Assignee | ||
Comment 16•9 years ago
|
||
I changed the code to show all the OS type info, and I put the code in the bottom.
Flags: needinfo?(j.parkouss)
Attachment #8677827 -
Flags: review+
Reporter | ||
Comment 17•9 years ago
|
||
(In reply to joridoss from comment #16) > Created attachment 8677827 [details] [review] > Pull request with the right info. > > I changed the code to show all the OS type info, and I put the code in the > bottom. This looks perfectly fine by me! Thanks for doing this. :) If you know how to do this, please rebase your commits to have only one for this patch (else I can do it). Also if you could ask for a review so I can r+ and land. (you have to select "?" in the r field, with my email address). Glad to see this!
Assignee: gioyik → joridoss
Flags: needinfo?(j.parkouss)
Assignee | ||
Comment 18•9 years ago
|
||
Can u rebase for me?
Reporter | ||
Comment 19•9 years ago
|
||
Yup, no problem - will do before landing. Please just ask for a review then.
Reporter | ||
Comment 20•9 years ago
|
||
Well, no real need for a review flag anyway, I'm totally happy with the changes. :) Rebased and landed in https://github.com/mozilla/mozregression/commit/b2db5044fd4ab2503bcf107f4f9385c4a58776c2. Thanks Joridoss!
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(gioyik)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•