Closed Bug 1165525 Opened 5 years ago Closed 5 years ago

Onboarding messaging poorly words how to turn off suggestions by implying blank is the only way

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 41
Iteration:
41.1 - May 25
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

Attachments

(6 files, 4 obsolete files)

From #developers:

4:30 PM <avih> gavin: iirc one of those pages suggested that the way to bail out of collecting info the user should use blank page. but i don't know how to bring the tour again and i don't recall the exact wording
4:31 PM <•gavin> that would surprise me because it's not correct
4:31 PM <avih> right, i was surprised as well. so it could be poor wording of that page
4:32 PM <•gavin> I see what you mean: https://cloudup.com/clTLSM7A-H4
4:32 PM <avih> gavin: browser.newtabpage.introShown=false and you'll get this tour
4:33 PM <avih> gavin: yes, exactly. so it is poor wording, right?
4:33 PM <•gavin> Mardak: seems like that should change to be "uncheck 'Include suggested sites'" intead of "selecting Show Blank Page"
4:33 PM <•gavin> avih: yes

attached is the image gavin linked of the onboarding page with text for turning things off by selecting blank.

I believe the string used came from bug 1147476 comment 3:

> [REQUIRED BY LEGAL] In order to provide this service, Mozilla collects and uses
> certain analytics information relating to the sites you visit in accordance
> with our Privacy Policy [link]. You can turn off this feature by clicking the
> gear button and even choose to see a blank page instead.
Ed, is this going to be fixed before this "tour" goes out?
Flags: needinfo?(edilee)
We have strings in Aurora 40, so we'll need to break string freeze to fix it. For uplift to 39, we can change the en-US hardcoded strings.

flod, how should we go about fixing this for Aurora 40? I'm assuming gavin wants it fixed for more than just Nightly 41.
Flags: needinfo?(edilee) → needinfo?(francesco.lodolo)
Attached patch wip (obsolete) — Splinter Review
I'd think it's quite important that users never see the current text, and personally I'd even say it might be better to delay it ( = the tour and/or the new menu terminology) to the next version such that it can be released with better text.

There was already one big cry when Firefox started putting ads and collecting info at the newtab page but it was clear how to prevent that.

The current text could be interpreted as further erosion of user privacy IMO, and we really don't want more FUD when technically there's no reason for it.

It's a first impression, and it must be super clear IMO. Releasing it with the current text and improving it for the next version is quite a bit less effective IMO than releasing it with better text in the first place - even if a bit later.
Attached patch v1 (obsolete) — Splinter Review
Attachment #8608397 - Attachment is obsolete: true
Attached image v1 screenshot (obsolete) —
(In reply to Ed Lee :Mardak from comment #6)
> Created attachment 8608400 [details]
> v1 screenshot

I think it's still not super clear that the data collection will only happen when "suggestions" is checked (assuming that's indeed the case - which according to gavin, it is the case).
(In reply to Avi Halachmi (:avih) from comment #4)
> I'd think it's quite important that users never see the current text
There were various decisions to use a more expressive channel to explain the intricacies of Tiles data and privacy. E.g., infographics, videos, and other documentation.

pfinch/kghim, do we have updated content that people can check out now?
Flags: needinfo?(pfinch)
Flags: needinfo?(kghim)
Yes, I imagine a lot of thought went into this, but the first time I saw it I was terrified that Firefox will not let me use thumbnails anymore without collecting (analytics/aggregated/hashed/etc) data on my browsing habits.

Still, if there is an option to make it super clear before sending the users to external help sites, I think that's preferable.

The main point to make clear IMO is that data collection is only associated with the "suggestions" checkbox.
(In reply to Avi Halachmi (:avih) from comment #9)
> Yes, I imagine a lot of thought went into this, but the first time I saw it
> I was terrified that Firefox will not let me use thumbnails anymore without
> collecting (analytics/aggregated/hashed/etc) data on my browsing habits.
> 
> Still, if there is an option to make it super clear before sending the users
> to external help sites, I think that's preferable.
> 
> The main point to make clear IMO is that data collection is only associated
> with the "suggestions" checkbox.

We will update the in-product page and link to SUMO, but that will be show after onboarding.  I do not think that solves the problem.
Flags: needinfo?(pfinch)
(In reply to Ed Lee :Mardak from comment #2)
> flod, how should we go about fixing this for Aurora 40? I'm assuming gavin
> wants it fixed for more than just Nightly 41.

You simply land strings on Aurora (with l10n=*NAME_OF_APPROVER* to bypass the string hook). The decision to break string freeze is up to release drivers, not really l10n.

My only concern is that this is a pretty important piece of information, something that you display once right in front of the user. Landing now means that it will potentially remain in English for some locales, making things worse instead of improving them. True is that we're not way too far into the cycle.

We don't send any data at all when Suggested tiles are disabled?
Flags: needinfo?(francesco.lodolo)
(In reply to Francesco Lodolo [:flod] (UTC+2) from comment #11)
> we're not way too far into the cycle.
I'll try to get the team to figure out what we'll do with the messaging today/Friday, so hopefully we can land/uplift soon.

> We don't send any data at all when Suggested tiles are disabled?
We turn off tiles data reporting if the user doesn't have "Include suggested sites" checked. Otherwise it sends back pings documented http://gecko.readthedocs.org/en/latest/browser/browser/DirectoryLinksProvider.html#id1
I think the language Ed suggested is good. I would change "You can turn off this feature" to "You can turn off this service" to align with the aforementioned service in the previous paragraph. 

"In order to provide this service, Mozilla collects and users certain analytics information relating to your use of the tiles in accordance with our Privacy Notice.

You can turn off this service by clicking the gear (*) button and unchecking “Include suggested sites” or selecting “Show blank page” in the New Tab Controls menu."  

Geoff, would this work?
Flags: needinfo?(kghim) → needinfo?(gpiper)
(In reply to Francesco Lodolo [:flod] (UTC+2) from comment #11)
> (In reply to Ed Lee :Mardak from comment #2)
> > flod, how should we go about fixing this for Aurora 40? I'm assuming gavin
> > wants it fixed for more than just Nightly 41.
> 
> You simply land strings on Aurora (with l10n=*NAME_OF_APPROVER* to bypass
> the string hook). The decision to break string freeze is up to release
> drivers, not really l10n.
> 
> My only concern is that this is a pretty important piece of information,
> something that you display once right in front of the user. Landing now
> means that it will potentially remain in English for some locales, making
> things worse instead of improving them. True is that we're not way too far
> into the cycle.

Adding one more note after talking with Pike and Jeff on IRC.

https://transvision.mozfr.org/string/?entity=browser/chrome/browser/newTab.properties:newtab.intro.paragraph4&repo=aurora
This is the current list of locales that already translated this string on Aurora.

One less disruptive approach would be to:
* Land a proper patch on mozilla-central (new text and new string ID).
* Land a patch that updates the text for en-US on mozilla-aurora, but keeps the existing string ID.
* Send out an email to dev-l10n about this change on mozilla-aurora.

The risk is that some locales won't update their localization on Aurora, but it seems preferable to displaying English text in a one-off screen.
Attached image v1.1 screenshot
feature -> service
selecting "Show blank page" -> unchecking "Include suggested sites"

As kghim mentioned, being consistent with using "service". Separately discussed was removing too many options "uncheck or select" to just have the one option. Given the UI with menu right next to it, it should be clear enough that selecting blank would also turn off the service.
Attachment #8608400 - Attachment is obsolete: true
Attached patch v1.1Splinter Review
Attachment #8608399 - Attachment is obsolete: true
Attachment #8608815 - Flags: review?(adw)
Attachment #8608815 - Flags: review?(adw) → review+
Blocks: 1140185
https://hg.mozilla.org/mozilla-central/rev/cc47f314c7d9
Assignee: nobody → edilee
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Iteration: --- → 41.1 - May 25
Points: --- → 2
Flags: needinfo?(gpiper)
Like so? Just the string change for uplift then a separate email?
Attachment #8610019 - Flags: feedback?(francesco.lodolo)
Attachment #8610019 - Attachment description: for aurora → for aurora (Mardak will land)
Attached patch for aurora (Mardak will land) (obsolete) — Splinter Review
Comment on attachment 8610019 [details] [diff] [review]
for aurora (Mardak will land)

Review of attachment 8610019 [details] [diff] [review]:
-----------------------------------------------------------------

Yes. I will take care of sending the email to dev-l10n.

(not sure why the two attachments).
Attachment #8610019 - Flags: feedback?(francesco.lodolo) → feedback+
Attachment #8610028 - Attachment is obsolete: true
verified on Nightly - 41.0a1 (2015-05-26):

Steps to verify:
1. Opened up new Firefox profile using ProfileSwitcher
2. Firefox Nightly First Run Page appears
3. Opened up new tab by clicking on the "+"
4. Onboarding tutorial overlay appears over the tiles
5. The second paragraph of the 3rd onboarding slide copy correctly appears as "You can turn off this service by clicking the gear (*) button and unchecking "Include suggested site" in the New Tab Controls menu. Screenshot attached.
Status: RESOLVED → VERIFIED
Attached image Verified screenshot
Attachment #8610904 - Flags: review+
Attachment #8610904 - Flags: review+
Comment on attachment 8610019 [details] [diff] [review]
for aurora (Mardak will land)

Approval Request Comment: See bug 1140185 comment 11
Attachment #8610019 - Flags: approval-mozilla-aurora?
It sounds like Flod is talking about this being in aurora. 
If this is uplifted to beta we will not have localizations for these strings for 39. 
Flod what are your concerns if we uplift this to beta?
Flags: needinfo?(francesco.lodolo)
(In reply to Liz Henry (:lizzard) from comment #26)
> It sounds like Flod is talking about this being in aurora. 
> If this is uplifted to beta we will not have localizations for these strings
> for 39. 
> Flod what are your concerns if we uplift this to beta?

The patch for beta doesn't have localizable strings, they're hard-coded in a JavaScript file, so no issue on that front. We only have localizable strings on aurora and central.
https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1165525&attachment=8610422
Flags: needinfo?(francesco.lodolo)
Great, thanks
http://hg.mozilla.org/releases/mozilla-aurora/rev/2ce1d8162c4a
Flags: qe-verify+
Flags: firefox-backlog+
Comment on attachment 8610019 [details] [diff] [review]
for aurora (Mardak will land)

approval-mozilla-aurora+ granted in bug 1140185 comment 14
Attachment #8610019 - Flags: approval-mozilla-aurora?
Verified fix on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit with latest Aurora, build ID: 20150528004000.
You need to log in before you can comment on or make changes to this bug.