Closed Bug 1165584 Opened 10 years ago Closed 10 years ago

Remove host from add-on installation error messages

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Iteration:
41.1 - May 25
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

patch
8.77 KB, patch
mossop
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review
We display the host in the notification's heading, so it doesn't need to re-appear in the message.
Attachment #8606626 - Flags: review?(dtownsend)
Flags: qe-verify-
Flags: firefox-backlog+
Attachment #8606626 - Flags: review?(dtownsend) → review+
Backed out: https://hg.mozilla.org/integration/fx-team/rev/d3b19b21a660 Not sure what's going on here: 485 INFO TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_badhash.js | uncaught exception - NS_ERROR_OUT_OF_MEMORY: Component returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsIStringBundle.formatStringFromName] at XStringBundle:37 503 INFO TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_badhashtype.js | uncaught exception - NS_ERROR_OUT_OF_MEMORY: Component returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsIStringBundle.formatStringFromName] at XStringBundle:37 548 INFO TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_httphash2.js | uncaught exception - NS_ERROR_OUT_OF_MEMORY: Component returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsIStringBundle.formatStringFromName] at XStringBundle:37 572 INFO TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_httphash6.js | uncaught exception - NS_ERROR_OUT_OF_MEMORY: Component returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsIStringBundle.formatStringFromName] at XStringBundle:37
(In reply to Dão Gottwald [:dao] from comment #2) > Not sure what's going on here: > > 485 INFO TEST-UNEXPECTED-FAIL | > toolkit/mozapps/extensions/test/xpinstall/browser_badhash.js | uncaught > exception - NS_ERROR_OUT_OF_MEMORY: Component returned failure code: > 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsIStringBundle.formatStringFromName] > at XStringBundle:37 Bug 698831. Very annoying.
https://hg.mozilla.org/mozilla-central/rev/2c5fe3692774
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: