Closed
Bug 1165594
Opened 9 years ago
Closed 9 years ago
New Tab controls looks broken with RTL locales
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
People
(Reporter: theo, Assigned: emtwo)
References
(Blocks 1 open bug)
Details
(Whiteboard: .?)
Attachments
(5 files)
25.62 KB,
image/png
|
Details | |
105.03 KB,
image/png
|
Details | |
1.38 MB,
image/png
|
Details | |
1.86 KB,
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
2.58 KB,
patch
|
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The New Tab controls menu (both the one on about:newtab and the one shown on New Tab intro) looks wrong in RTL locales.
Reporter | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → msamuel
Updated•9 years ago
|
Updated•9 years ago
|
Iteration: --- → 41.3 - Jun 29
Assignee | ||
Comment 2•9 years ago
|
||
Attaching screenshot for RTL changes.
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8621401 -
Flags: review?(edilee)
Comment 4•9 years ago
|
||
Comment on attachment 8621401 [details] [diff] [review] v1: Appropriately style new tab cog menu for RTL >+++ b/browser/base/content/newtab/newTab.css >@@ -578,16 +578,42 @@ input[type=button] { > .newtab-customize-complex-option { > width: 100%; > display: block; > text-align: left; > max-width: 300px; > background-color: #F9F9F9; > } > >+.newtab-customize-panel-item:-moz-locale-dir(rtl), >+.newtab-customize-complex-option:-moz-locale-dir(rtl) { >+ text-align: right; We should just use text-align: start >+.newtab-customize-panel-item:-moz-locale-dir(rtl) { >+ padding: 15px 40px 15px 15px; We shouldn't need to override all the other paddings. And simpler from the non-rtl styling, we should be able to use the following and not need special rtl styling: padding: 15px; -moz-padding-end: 40px;
Attachment #8621401 -
Flags: review?(edilee) → review+
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/916dbfe51789
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
status-firefox40:
--- → affected
Updated•9 years ago
|
Points: --- → 3
Assignee | ||
Comment 7•9 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: bug 1158859 [User impact if declined]: The new tab controls will look broken in RTL locales (refer to screenshots) [Describe test coverage new/current, TreeHerder]: Tested on nightly and locally on aurora [Risks and why]: Low risk - css only [String/UUID change made/needed]: N/A (Note: Should be applied on top of bug 1172987)
Attachment #8622728 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
Comment on attachment 8622728 [details] [diff] [review] [aurora] Appropriately style new tab cog menu for RTL Visual regression, taking it.
Attachment #8622728 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/1cec67224d77
Comment 10•9 years ago
|
||
Confirming the fix with the He/Ar locales. Also verified with the en-US locale by changing the text direction to RTL. Tested on Mac OS X 10.10.4, Ubuntu 12.04 32-bit, Windows 7 64-bit and Windows 10 64-bit using: - latest DevEdition, build ID: 20150730004009, - Firefox 40.0b9, build ID: 20150730171029.
You need to log in
before you can comment on or make changes to this bug.
Description
•