Closed Bug 1165594 Opened 4 years ago Closed 4 years ago

New Tab controls looks broken with RTL locales

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 41
Iteration:
41.3 - Jun 29
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: tchevalier, Assigned: emtwo)

References

(Blocks 1 open bug)

Details

(Whiteboard: .?)

Attachments

(5 files)

The New Tab controls menu (both the one on about:newtab and the one shown on New Tab intro) looks wrong in RTL locales.
Attached image Intro, Arabic
Blocks: 1145418
Assignee: nobody → msamuel
Blocks: 1140185
No longer blocks: 1145418
Iteration: --- → 41.3 - Jun 29
Attached image rtl_menu.png
Attaching screenshot for RTL changes.
Comment on attachment 8621401 [details] [diff] [review]
v1: Appropriately style new tab cog menu for RTL

>+++ b/browser/base/content/newtab/newTab.css
>@@ -578,16 +578,42 @@ input[type=button] {
> .newtab-customize-complex-option {
>   width: 100%;
>   display: block;
>   text-align: left;
>   max-width: 300px;
>   background-color: #F9F9F9;
> }
> 
>+.newtab-customize-panel-item:-moz-locale-dir(rtl),
>+.newtab-customize-complex-option:-moz-locale-dir(rtl) {
>+  text-align: right;
We should just use text-align: start

>+.newtab-customize-panel-item:-moz-locale-dir(rtl) {
>+  padding: 15px 40px 15px 15px;
We shouldn't need to override all the other paddings. And simpler from the non-rtl styling, we should be able to use the following and not need special rtl styling:

padding: 15px;
-moz-padding-end: 40px;
Attachment #8621401 - Flags: review?(edilee) → review+
https://hg.mozilla.org/mozilla-central/rev/916dbfe51789
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Points: --- → 3
Approval Request Comment
[Feature/regressing bug #]: bug 1158859

[User impact if declined]: The new tab controls will look broken in RTL locales (refer to screenshots)

[Describe test coverage new/current, TreeHerder]: Tested on nightly and locally on aurora

[Risks and why]: Low risk - css only

[String/UUID change made/needed]: N/A

(Note: Should be applied on top of bug 1172987)
Attachment #8622728 - Flags: approval-mozilla-aurora?
Comment on attachment 8622728 [details] [diff] [review]
[aurora] Appropriately style new tab cog menu for RTL

Visual regression, taking it.
Attachment #8622728 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Confirming the fix with the He/Ar locales. Also verified with the en-US locale by changing the text direction to RTL.

Tested on Mac OS X 10.10.4, Ubuntu 12.04 32-bit, Windows 7 64-bit and Windows 10 64-bit using:
- latest DevEdition, build ID: 20150730004009,
- Firefox 40.0b9, build ID: 20150730171029.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.