Closed Bug 1165600 Opened 10 years ago Closed 10 years ago

[Settings] Migrate to tagged template strings

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.2 S13 (29may)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[gaia] KevinGrandon:bug_1165600_settings_sim_tagged > mozilla-b2g:master
46 bytes, text/x-github-pull-request
eragonj
: review+
Details | Review
For security reasons and consistency we are porting all template.js usage over to our tagged template string handling.
Comment on attachment 8606675 [details] [review] [gaia] KevinGrandon:bug_1165600_settings_sim_tagged > mozilla-b2g:master Arthur - could you please take a look if you get a chance? Thanks!
Attachment #8606675 - Flags: review?(arthur.chen)
Comment on attachment 8606675 [details] [review] [gaia] KevinGrandon:bug_1165600_settings_sim_tagged > mozilla-b2g:master EJ, mind take a look at this patch? Thanks!
Attachment #8606675 - Flags: review?(arthur.chen) → review?(ejchen)
Comment on attachment 8606675 [details] [review] [gaia] KevinGrandon:bug_1165600_settings_sim_tagged > mozilla-b2g:master Thanks Kevin, this patch looks nice ! r+
Attachment #8606675 - Flags: review?(ejchen) → review+
Thank you for the review!
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S13 (29may)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: