1165606 - Annotation history deletion can remove the starred state of the job, unexpected UX

Status: NEW

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

There is the broader question raised by Mauro in channel about the usefulness of the classification history in the Annotations tabs (should we preserve it at all) but I happened across this use case and I think several bugs:

Steps to reproduce:
(setup)
o load any push, select a job, and pin it
o select a classification type (eg. infra, intermittent) and save it
o re-pin the job and re-classify it as another type
o repeat one more time

- so you now have a job with 3 classification 'events' in the Annotations tab, and one 'current' classification type which shows up in the bottom left pane.

So now..
o delete the middle classification in the Annotation history
o (bug1) the job state changes as though it's been un-classified
- after several seconds, that job state will re-appear as correctly classified
o delete the last classification in the Annotation history (not the current one)
o (bug2) the job state changes to un-classified and stays there

So in addition to the question of whether we should be keeping track of classification history, I also wonder what does it 'mean' to delete prior classification events.

Should we only present the trash can UI adjacent to the current classification? Should prior classifications remain permanent?

Not sure but just wondering.. :)

Comment 1

[Jonathan French (:jfrench)]

Attachment: bug1

Comment 2

[Jonathan French (:jfrench)]

Attachment: bug2

Comment 3

[Jonathan French (:jfrench)]

Attachment: stepsToReproStartPoint