Closed Bug 1165656 Opened 9 years ago Closed 9 years ago

Escape button not working

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jeetsaahil.18, Assigned: omarS, Mentored)

References

Details

(Keywords: access, Whiteboard: [ktlo][good first bug]) 

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.152 Safari/537.36

Steps to reproduce:

1. Select any app on marketplace.
2. Click on give review.A pop up opens up to fill the review.
3. Try to close the popup with Escape button but doesn't work, have to click outside of the popup.


Actual results:

Popup opened up but didn't get closed by pressing Escape button.


Expected results:

Popup should have been closed by pressing Escape button.
This would be good as a rule for modals.
Component: General → Consumer Pages
Keywords: access
Priority: -- → P2
Whiteboard: [ktlo]
Status: UNCONFIRMED → NEW
Ever confirmed: true
Andres is a new contributor who has just set up his dev environment. Assigning to him as a goodfirstbug!
Assignee: nobody → a.omarserrano
Mentor: vaishnav.rd
Whiteboard: [ktlo] → [ktlo][good first bug]
Created a pull request: https://github.com/mozilla/marketplace-elements/pull/19
Flags: needinfo?(vaishnav.rd)
Can I work on this bug? I'm new on Bugzilla.
Hi Nikhil, welcome! Andres just started working on this bug, and is waiting for guidance, so I wouldn't recommend taking this one. Here is a query of goodfirstbugs that haven't had any comments for two weeks: http://mzl.la/1Px4N3H. Feel free to ask to take over any of these instead. Thanks
NI'ing Kevin for r?
Flags: needinfo?(vaishnav.rd) → needinfo?(kngo)
Kevin is out today, so hopefully he can get to this soon--sorry for the delay!
I think it's ok because I received some feedback today from Davor and will need to make one more adjustment and submit again.
Any progress on this? If this is still unchanged in two weeks, we'll unassign it.
Flags: needinfo?(kngo) → needinfo?(a.omarserrano)
(In reply to Andres O Serrano [:omarS] from comment #4)
> Created a pull request:
> https://github.com/mozilla/marketplace-elements/pull/19

The pr has been merged. Thanks Andres for the contribution!
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(a.omarserrano)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.