Open Bug 1165675 Opened 10 years ago Updated 3 years ago

Investigate removing fill-rule and clip-rule attributes from theme SVGs

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

People

(Reporter: ntim, Unassigned)

Details

I have tried removing those attributes on some SVGs, and I didn't notice any visible effect. List of files that have those attributes (may not be complete) : browser/components/loop/* browser/themes/shared/devtools/images/profiler-stopwatch-*.svg browser/themes/shared/devtools/images/tool-*.svg browser/themes/shared/devedition/search.svg toolkit/themes/shared/reader/* browser/themes/shared/incontent-icons/tab-crashed.svg browser/themes/*/content-contextmenu.svg toolkit/themes/*/global/icons/autocomplete-search.svg
Robert, do you know if it's safe to remove those attributes ? MDN says clip-rule is only useful in clipPath, I didn't quite understand the utility of fill-rule though.
Flags: needinfo?(longsonr)
If you're not the child of a clipPath then clip-rule does nothing. If you are the child of a clipPath then fill-fule does nothing. Beats me why SVG decided to have two properties for the same concept. fill-rule/clip-rule comes into play with paths that wind backwards and forwards clockwise and anticlockwise so you can generate shapes with holes in them. The SVG specification has a pretty good example of this. http://www.w3.org/TR/SVG/painting.html#FillRuleProperty clip-rule works the same way for clipPath children.
Flags: needinfo?(longsonr)
For child you should strictly read descendant.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.