1165744 - /comm-central/mailnews/news/src/nsNntpService.cpp:732:94: error: expected primary-expression before ‘(’ token if (StringBeginsWith(list[index], NS_LITERAL_CSTRING(kNewsRootURI)))

Status: RESOLVED DUPLICATE of bug 1165737

(Thunderbird :: Untriaged, defect)

Description

[ISHIKAWA, Chiaki (I will be tied up until Dec 14 with day job events.)]

Attachment: nsNewsUtils.h: define kNewsRootURI as preprocessor macro.

After refreshing my source a few hours ago, my local C-C source tree could not build thunderbird.

The error was
/comm-central/mailnews/news/src/nsNntpService.cpp:732:94: error: expected primary-expression before ‘(’ token
       if (StringBeginsWith(list[index], NS_LITERAL_CSTRING(kNewsRootURI)))
                 
After checking a few things, I realize this is the change made to NS_LITERAL_CSTRING in
Bug 1155963 - Don't allow NS_NAMED_LITERAL_CSTRING(name, NS_LITERAL_CSTRING("value"))

I needed the attached patch to compile and build TB.

We now define kNewsRootURI as CPP macros.
Surprisingly, other strings defined nsNewsUtils.h did not need
the change, but I am now a little suspicious about why only kNewsRootURI needed this special handling. Other constants seem to be simply compared using basic strcmp() and friends.

At least, the built TB now starts.

TIA

Comment 1

[[e-mail]]

Sorry, but you were too slow - bug 1165737 was filed and resolved to cover this issue.

Comment 2

[ISHIKAWA, Chiaki (I will be tied up until Dec 14 with day job events.)]

(In reply to [e-mail] from comment #1)
> Sorry, but you were too slow - bug 1165737 was filed and resolved to cover
> this issue.

Yes, I was late :-)
But the bug is fixed. Good.

TIA

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8606768 [details] [diff] [review]
nsNewsUtils.h: define  kNewsRootURI as preprocessor macro.

I don't think we need my review here anymore, right?  ;)

Comment 4

[ISHIKAWA, Chiaki (I will be tied up until Dec 14 with day job events.)]

(In reply to Blake Winton (:bwinton) from comment #3)
> Comment on attachment 8606768 [details] [diff] [review]
> nsNewsUtils.h: define  kNewsRootURI as preprocessor macro.
> 
> I don't think we need my review here anymore, right?  ;)

Right. Sorry, I didn't realize setting status "RESOLVED" and "DUPLICATE" did not reset the review request.