[bluetooth2] Cannot build for flame-kk

RESOLVED DUPLICATE of bug 1165835

Status

()

Core
DOM
RESOLVED DUPLICATE of bug 1165835
3 years ago
3 years ago

People

(Reporter: janjongboom, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

With patches from bug 1165184 to enable BLE against today's mc, build fails:

../../../../gecko-dev/dom/bluetooth/bluetooth2/BluetoothAdapter.cpp: In member function 'bool mozilla::dom::bluetooth::BluetoothAdapter::IsBluetoothCertifiedApp()':
../../../../gecko-dev/dom/bluetooth/bluetooth2/BluetoothAdapter.cpp:986:59: error: no matching function for call to 'nsIPrincipal::GetOrigin(nsCGetterCopies)'
../../../../gecko-dev/dom/bluetooth/bluetooth2/BluetoothAdapter.cpp:986:59: note: candidate is:
In file included from ../../dist/include/mozilla/dom/ScriptSettings.h:14:0,
                 from ../../dist/include/mozilla/dom/CallbackObject.h:28,
                 from ../../dist/include/mozilla/dom/CallbackInterface.h:19,
                 from ../../dist/include/mozilla/dom/EventListenerBinding.h:10,
                 from ../../dist/include/mozilla/EventListenerManager.h:11,
                 from ../../dist/include/mozilla/DOMEventTargetHelper.h:19,
                 from ../../../../gecko-dev/dom/base/DOMRequest.h:12,
                 from ../../../../gecko-dev/dom/bluetooth/bluetooth2/BluetoothAdapter.cpp:10:
../../dist/include/nsIPrincipal.h:65:20: note: virtual nsresult nsIPrincipal::GetOrigin(nsACString_internal&)
../../dist/include/nsIPrincipal.h:65:20: note:   no known conversion for argument 1 from 'nsCGetterCopies' to 'nsACString_internal&'
Created attachment 8606979 [details] [diff] [review]
bug1165872.diff

This compiles, but I guess the getter_Copies() call is there for a reason.
Attachment #8606979 - Flags: review?(joliu)
Hi Jan,

The same patch has been provided in Bug 1165835 and landed on b2g-inbound.
Thanks for your time. :)

Regards,
Jocelyn
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1165835
Comment on attachment 8606979 [details] [diff] [review]
bug1165872.diff

Review of attachment 8606979 [details] [diff] [review]:
-----------------------------------------------------------------

Cancel the review request since this patch is already provided and landed on b2g-inbound.
Attachment #8606979 - Flags: review?(joliu)
You need to log in before you can comment on or make changes to this bug.