1165905 - JS_GetGlobalJitCompilerOption should handle all options

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

Just noticed this:

js> getJitCompilerOptions()["ion.gvn.enable"]
0

The problem is that JS_GetGlobalJitCompilerOption returns 0 for unknown options. It should probably MOZ_CRASH.

Some jit-tests do:

    var oldOpts = getJitCompilerOptions();
    ...
    for (var k in oldOpts)
        setJitCompilerOption(k, oldOpts[k]);

Because of this bug, this will currently disable some options like GVN.

Comment 1

[Nicolas B. Pierron [:nbp]]

I guess a simple self-test would be to verify that getJitCompilerOptions returns an object which has identical properties and values.

    load(libdir + "asserts.js");
    var oldOpts = getJitCompilerOptions();
    for (var k in oldOpts)
        setJitCompilerOption(k, oldOpts[k]);
    var newOpts = getJitCompilerOptions();
    assertDeepEq(oldOpts, newOpts);

Comment 2

[Jon Coppeard (:jonco)]

Attachment: bug1165905-compiler-options

Patch to make this fallible and fail for unknown options.  Testcase as suggested.  The API itself doesn't seem to be used outside the engine.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8798054 [details] [diff] [review]
bug1165905-compiler-options

Review of attachment 8798054 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c2db6614dbe
Make JS_GetGlobalJitCompilerOption fail for unknown options r=jandem

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4c2db6614dbe