The "Autotheme >" link on the Detail panel is broken

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: etienne, Assigned: hub)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
It does nothing an eventually errors.

According to the spec it shouldn't be here anyway so we should remove it and make sure we're not leaving dead code.
(Reporter)

Updated

4 years ago
Blocks: 1133768
Priority: -- → P1
Is it possible that it's not in the spec because the specifier did not see it was here originally ?

I still think it's a useful feature to convert an existing theme -- but maybe that's just me :)
(Reporter)

Comment 2

4 years ago
I still want to keep in on the new theme dialog so that you can make autotheme without going though the webactivity.

But doing it on an existing theme will erase the prior colors so I think it's more confusing than helping.
Yeah makes sense !
(Assignee)

Updated

4 years ago
Summary: The "Autothme >" link on the Detail panel is broken → The "Autotheme >" link on the Detail panel is broken
(Assignee)

Comment 4

4 years ago
Created attachment 8616334 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/20

Remove the HTML. The JS code is actually used elsewhere.
Assignee: nobody → hub
Status: NEW → ASSIGNED
Attachment #8616334 - Flags: review?(etienne)
(Reporter)

Comment 5

4 years ago
https://github.com/fxos/studio/commit/2a63e288b4533abd79648b8fc6393fbf9c083ff9
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Updated

4 years ago
Attachment #8616334 - Flags: review?(etienne) → review+
You need to log in before you can comment on or make changes to this bug.