1166009 - New rule additions to the job visibility profile don't take effect until the rule is saved

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect, P2)

Description

[Ryan VanderMeulen [:RyanVM]]

Today, I created two new visibility rules. I then added them to the default visibility profile. I reloaded the page (even tried a force reload), but the jobs were still visible. I re-opened the rules and saved them (making no changes to them otherwise). Reloaded and the jobs were then hidden.

Comment 1

[Cameron Dawson [:camd]]

Hit this today.  Dustin has entered a Tier-2 profile for some jobs while he posted them to Try.  He then enabled them to post to m-i.  They weren't Tier-2 because the signature for the exclusion with those parameters only existed for try at the time it was created.  

To make them Tier-2 on mozilla-inbound, you just had to go re-save the exclusion profile.

we may want to consider having the signature not include the repo.  Then we'd have to query by 2 fields in stead of just 1.  But it would allow them to be more reusable.

This applies both to Tier-2 and exclusion in general.

Comment 2

[Cameron Dawson [:camd]]

Philor also mentioned that this can happen with the opts, too.  Job setup when it had never been posted for "debug" but had for "opt".  Both options are set in the exclusion profile, but no signature for "opt" existed yet.  So you have to re-save the profile again.

Maybe we just need a scheduled task that re-saves all the profiles every once in a while...  :)  That would be a sweet hack!

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Or maybe if an exclusion has no matching signature, occasionally recheck it to see if it does now?

Comment 5

[Ed Morley [:emorley]]

We're going to replace exclusion profiles with people always using the in-tree (mozilla-central) tier values instead (bug 1387640).