Closed Bug 1166037 Opened 5 years ago Closed 5 years ago

ARM64: Import Baseline

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Unspecified
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: sstangl, Assigned: sstangl)

References

Details

Attachments

(2 files)

This bug is for the small Baseline changes for ARM64, and for the ARM64-specific Baseline code. I should have addressed all the review points raised from the reviews in Bug 1088326. Making separate bugs for each component for the sake of organization.

The intention is to land these patches independent of the other ARM64 patches ASAP, then hook them all together with a build system patch at the end.

Patch 1/2: Modifications to shared code, which mostly just involves not saying "BaselineStackReg" anymore.
Attachment #8607183 - Flags: review?(kvijayan)
Part 2: Import ARM64-specific Baseline code.
Attachment #8607185 - Flags: review?(kvijayan)
Comment on attachment 8607183 [details] [diff] [review]
0001-Modify-common-Baseline-code-for-ARM64.patch

Review of attachment 8607183 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/BaselineBailouts.cpp
@@ +1556,5 @@
>  
>      // Do stack check.
>      bool overRecursed = false;
> +    BaselineBailoutInfo *info = builder.info();
> +    uint8_t *newsp = info->incomingStack - (info->copyStackTop - info->copyStackBottom);

Nit: use new pointer-syntax conventions.

"T* varname" not "T *varname"
Attachment #8607183 - Flags: review?(kvijayan) → review+
Attachment #8607185 - Flags: review?(kvijayan) → review+
Assignee: nobody → sstangl
https://hg.mozilla.org/mozilla-central/rev/2372db222b85
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.