Clean up and add expected result strings to test_hmac.js

RESOLVED FIXED in Firefox 41

Status

()

Core
Security: PSM
--
minor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

Trunk
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
The main goal is to add expected result strings, but the file currently has several issues that can be cleaned up as well:
 - Trailing whitespace
 - Typos
 - Uses var instead of let
... etc
(Assignee)

Comment 1

3 years ago
Created attachment 8607246 [details]
MozReview Request: bz://1166078/Cykesiopka

/r/8977 - Bug 1166078 - Clean up and add expected result strings to test_hmac.js.

Pull down this commit:

hg pull -r d3f90cad944d228b66e2c545e835f170a622bde6 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8607246 - Flags: review?(dkeeler)
Attachment #8607246 - Flags: review?(dkeeler) → review+
Comment on attachment 8607246 [details]
MozReview Request: bz://1166078/Cykesiopka

https://reviewboard.mozilla.org/r/8975/#review7629

Ship It!
(Assignee)

Comment 4

3 years ago
Thanks for the review.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e865c20b124
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/360e42b79297
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Assignee)

Comment 7

3 years ago
Comment on attachment 8607246 [details]
MozReview Request: bz://1166078/Cykesiopka
Attachment #8607246 - Attachment is obsolete: true
Attachment #8620318 - Flags: review+
(Assignee)

Comment 8

3 years ago
Created attachment 8620318 [details]
MozReview Request: Bug 1166078 - Clean up and add expected result strings to test_hmac.js.
You need to log in before you can comment on or make changes to this bug.