1166118 - wrong signature used on ingesting raptor jobs as well as generating exclusion profiles for them

Status: RESOLVED DUPLICATE of bug 1193372

(Tree Management :: Treeherder: Data Ingestion, defect, P2)

Description

[Cameron Dawson [:camd]]

I found this when investigating why come jobs can't be hidden on Gaia.  They have the symbol se2, se1 and a few others in the "raptor" platform.

There are several signatures for those symbols and various permutations in the ``reference_data_signatures`` table.  

This is causing two issues:

1. the jobs, when ingested, are using what appears to be the wrong ones.
2. when trying to hide these jobs, the exclusion profile code is getting the wrong signature to hide, causing them not to get hidden.

Comment 1

[Cameron Dawson [:camd]]

I consider this a P1 because it's a data integrity issue.

Comment 2

[Ed Morley [:emorley]]

I'm not sure if this is related at all, but I noticed what seems to be a few mistakes in the platform/job name/job symbol code:

In _add_platform():
https://github.com/mozilla/treeherder/blob/acbc0b6d362880e2a3dbae7ae2ffda0d1ce33bd4/treeherder/model/derived/refdata.py#L438
            # WHERE clause for the retrieval SELECT
            where_filters.append(
                "(`os_name` = %s  AND `platform` = %s  AND `architecture` = %s)".format(
                    os_name, platform, arch
                )
            )

In _add_name_and_symbol():
https://github.com/mozilla/treeherder/blob/acbc0b6d362880e2a3dbae7ae2ffda0d1ce33bd4/treeherder/model/derived/refdata.py#L499
            where_filters.append(
                "(`name` = %s  AND `symbol` = %s)".format(name, symbol)
            )

Using "%s" with .format() doesn't work. eg:

>>> print "(`name` = %s  AND `symbol` = %s)".format("Foo", "F")
(`name` = %s  AND `symbol` = %s)

Comment 3

[Ed Morley [:emorley]]

(Filed bug 1170038 for that, since we should probably fix it either way)

Comment 4

[Ed Morley [:emorley]]

Cameron, is this a dupe of bug 1193372?

Comment 5

[Cameron Dawson [:camd]]

Ed: yeah, I think it is.  Marking it as such.  But I'll comment in the other bug that they should check this one as a test case.