1166121 - Record rudimentary visit types

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Richard Newman [:rnewman]]

Short-term version of Bug 1166084. Let's just track typed, call everything else 'link', and ignore reader mode transitions.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Pull req.

There's a commit right at the end of the sync-history pull request. Wes, could you take a look?

This is the simplest thing I think can work. We track WKNavigations as a result of loadRequests, either ignoring them (in the case of reader transitions) or marking them as 'typed'. Everything else that's not ignored is 'link'.


Manually verified that typed URLs are recorded as typed, links are recorded as links, and reader mode transitions are ignored:


2015-05-18 18:06:58.398 [Debug] [Profile.swift:143] onLocationChange: Recording visit for http://m.slashdot.org/ with type 2.
2015-05-18 18:06:58.399 [Debug] [SQLiteHistory.swift:227] recordVisitedSite: Setting title to Slashdot for URL http://m.slashdot.org/

2015-05-18 18:07:26.738 [Debug] [Profile.swift:143] onLocationChange: Recording visit for http://news.sciencemag.org/biology/2015/05/could-computer-predict-next-pandemic with type 1.

2015-05-18 18:07:26.738 [Debug] [SQLiteHistory.swift:227] recordVisitedSite: Setting title to Could a computer predict the next pandemic? | Science/AAAS | News for URL http://news.sciencemag.org/biology/2015/05/could-computer-predict-next-pandemic

2015-05-18 18:07:39.312 [Debug] [BrowserViewController.swift:489] ignoreNavigationInTab(_:navigation:): Ignoring nav: <WKNavigation: 0x7f94bd1471b0> (Optional(http://localhost:57548/reader-mode/page?url=http%3A%2F%2Fnews%2Esciencemag%2Eorg%2Fbiology%2F2015%2F05%2Fcould%2Dcomputer%2Dpredict%2Dnext%2Dpandemic)).

2015-05-18 18:07:39.628 [Debug] [Profile.swift:147] onLocationChange: Ignoring navigation for Optional(http://news.sciencemag.org/biology/2015/05/could-computer-predict-next-pandemic).

2015-05-18 18:07:54.103 [Debug] [BrowserViewController.swift:489] ignoreNavigationInTab(_:navigation:): Ignoring nav: <WKNavigation: 0x7f94bad60b80> (Optional(http://news.sciencemag.org/biology/2015/05/could-computer-predict-next-pandemic)).

2015-05-18 18:07:55.493 [Debug] [Profile.swift:147] onLocationChange: Ignoring navigation for Optional(http://news.sciencemag.org/biology/2015/05/could-computer-predict-next-pandemic).

Comment 2

[Richard Newman [:rnewman]]

Yes, there's a pile of debugging stuff in here. We can strip that out before we GTB, or now; up to you.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8607279 [details] [review]
Pull req.

Some nits but mostly questions. Looks good!

Comment 4

[Richard Newman [:rnewman]]

Thanks, Wes. Will land on top of the history sync stuff.

Comment 5

[Richard Newman [:rnewman]]

Merged: a55d62c