1166124 - "Buffer capacity" doesn't make sense

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Victor Porof [:vporof][:vp]]

When starting a recording, the text shows "buffer capacity: 0%". It just occurred to me that this doesn't make sense at all! The "buffer capacity" is at 100% actually, because it's empty.

ca·pac·i·ty
kəˈpasədē/
noun
noun: capacity

    1.
    the maximum amount that something can contain.
    "the capacity of the freezer is 1.1 cubic feet"
    synonyms:	volume, size, magnitude, dimensions, measurements, proportions
    "the capacity of the freezer"

So we're basically saying "our buffer's volume is zero", meaning that we're full before even starting.

We need to change this word to something accurate, or reverse the percentage.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

oops

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Chrome has "Buffer usage x%", and not a fan of that either -- any good words for this? I still think it should increment to 100% as opposed to 0%.

Comment 3

[Victor Porof [:vporof][:vp]]

Buffer x% full.

Comment 4

[Victor Porof [:vporof][:vp]]

Buffer available: x%

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Victor Porof [:vporof][:vp] from comment #3)
> Buffer x% full.

+1

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1166124-buffer-string.patch

note, we cannot change l10n strings for 40.1.

Comment 7

[Victor Porof [:vporof][:vp]]

Maybe we can if we ask nicely.

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8607811 [details] [diff] [review]
1166124-buffer-string.patch

Review of attachment 8607811 [details] [diff] [review]:
-----------------------------------------------------------------

Please file a follow up for proper l10n

Comment 9

[Jordan Santell [:jsantell] [@jsantell]]

already added to bug 1163763

Comment 10

[Jordan Santell [:jsantell] [@jsantell]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/8803f388005c
remote:   https://hg.mozilla.org/integration/fx-team/rev/10fc07861f4c

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8803f388005c

Comment 12

[Brian Grinstead [:bgrins]]

Comment on attachment 8607811 [details] [diff] [review]
1166124-buffer-string.patch


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None

Comment 13

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0940df6a02e2

Comment 14

[Brian Grinstead [:bgrins]]

Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8607811 [details] [diff] [review]
1166124-buffer-string.patch

Change approved to skip one train as part of the spring campaign.

Comment 16

[Andrei Vaida [:avaida]]

Verified fixed on Aurora 40.0a2 (2015-06-04), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.8.5.

The text shows "Buffer x% full".