Closed Bug 1166124 Opened 5 years ago Closed 5 years ago

"Buffer capacity" doesn't make sense

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set

Tracking

(firefox40 verified, firefox41 fixed)

VERIFIED FIXED
Firefox 41
Tracking Status
firefox40 --- verified
firefox41 --- fixed

People

(Reporter: vporof, Assigned: jsantell)

References

Details

Attachments

(1 file)

When starting a recording, the text shows "buffer capacity: 0%". It just occurred to me that this doesn't make sense at all! The "buffer capacity" is at 100% actually, because it's empty.

ca·pac·i·ty
kəˈpasədē/
noun
noun: capacity

    1.
    the maximum amount that something can contain.
    "the capacity of the freezer is 1.1 cubic feet"
    synonyms:	volume, size, magnitude, dimensions, measurements, proportions
    "the capacity of the freezer"

So we're basically saying "our buffer's volume is zero", meaning that we're full before even starting.

We need to change this word to something accurate, or reverse the percentage.
Chrome has "Buffer usage x%", and not a fan of that either -- any good words for this? I still think it should increment to 100% as opposed to 0%.
Buffer x% full.
Buffer available: x%
(In reply to Victor Porof [:vporof][:vp] from comment #3)
> Buffer x% full.

+1
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
note, we cannot change l10n strings for 40.1.
Attachment #8607811 - Flags: review?(nfitzgerald)
Maybe we can if we ask nicely.
Comment on attachment 8607811 [details] [diff] [review]
1166124-buffer-string.patch

Review of attachment 8607811 [details] [diff] [review]:
-----------------------------------------------------------------

Please file a follow up for proper l10n
Attachment #8607811 - Flags: review?(nfitzgerald) → review+
already added to bug 1163763
https://hg.mozilla.org/mozilla-central/rev/8803f388005c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Flags: qe-verify+
Comment on attachment 8607811 [details] [diff] [review]
1166124-buffer-string.patch


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None
Attachment #8607811 - Flags: approval-mozilla-aurora?
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment on attachment 8607811 [details] [diff] [review]
1166124-buffer-string.patch

Change approved to skip one train as part of the spring campaign.
Attachment #8607811 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Aurora 40.0a2 (2015-06-04), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.8.5.

The text shows "Buffer x% full".
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.