1166157 - Implement enumerating method for nsTArray which allows removing element

Status: RESOLVED INVALID

(Core :: XPCOM, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

We should have an enumerating method for nsTArray like nsTHashtable::EnumerateEntries, which allows removing elements.

A bonus would be that we could do it with lambda, so that we don't need to use a "void* aUserArg" hack.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8607345 [details] [diff] [review]
patch

Review of attachment 8607345 [details] [diff] [review]:
-----------------------------------------------------------------

Why not change the iterator returned by begin()/end()/etc. to be stable in the face of removals?

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

To make the iterator removal-stable, we would have to either accept a terrible O(n) time for each removal, or add burden to normal iterating which doesn't need to remove elements.

I guess the first opinion is probably fine, as we probably won't usually do removal that frequently.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

It's probably tricky to make iterator support removal, especially consider that the direction of an iterator can be reversed.

Probably we could just use std::remove_if.