Closed Bug 1166176 Opened 5 years ago Closed 5 years ago

[cleanup] Simplify volume related code in OPP manager

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Tracking Status
firefox41 --- fixed

People

(Reporter: ben.tian, Assigned: ben.tian)

Details

Attachments

(1 file, 1 obsolete file)

Changes
- simplify comment in function |HandleVolumeStateChanged|
- simplify code in function |AcquireSdcardMountLock|
- remove unused member variable |mNeedsUpdatingSdpRecords|
Assignee: nobody → btian
Attachment #8607388 - Flags: review?(shuang)
Comment on attachment 8607388 [details] [diff] [review]
Patch 1 (v1): Simplify volume related code in OPP manager

Review of attachment 8607388 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothOppManager.cpp
@@ +318,5 @@
>    }
>  
> +  /**
> +   * Disconnect ongoing OPP connection when a volume becomes non-mounted,
> +   * in case files of transfer locate on that volume. |OnSocketDisconnect|

nit: in case files of transfer are located...
Attachment #8607388 - Flags: review?(shuang) → review+
Revise based on reviewer's comment.
Attachment #8607388 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/63b96e7e7bb4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.