Closed Bug 1166184 Opened 7 years ago Closed 5 years ago

Eliminate SetObjectElement calls on Treeherder

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jandem, Assigned: jandem)

References

Details

I was profiling a Treeherder page load yesterday and noticed we spend about 8% in SetObjectElement. Angular has an apparently very hot "extend" function, that does:

    for (var keys = Object.keys(obj), j = 0, jj = keys.length; jj > j; j++) {
        var key = keys[j];
        dst[key] = obj[key]
    }

The first problem is that IonBuilder doesn't use a SETELEM cache if the access isn't dense or typed array; we probably need a new SetElement stub to handle this case.
Component: JavaScript Engine → JavaScript Engine: JIT
Depends on: 1209118
Depends on: 1214126
The issue in comment 0 was fixed by bug 1214126, I'll just close this.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.