Closed Bug 1166214 Opened 9 years ago Closed 9 years ago

Make BaseModule.SUB_MODULES support subdirectory

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: lchang, Assigned: lchang)

Details

Attachments

(1 file)

[gaia] luke-chang:1166214_basemodule_support_subdirectory > mozilla-b2g:master
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
In order to support following expressions.

  App.SUB_MODULES = [
    'ModuleA',
    'path/to/ModuleB'
  ];

Note that the module names (without path) should be always unique even though they're under different folder.
Comment on attachment 8607440 [details] [review]
[gaia] luke-chang:1166214_basemodule_support_subdirectory > mozilla-b2g:master

Hi Alive,

Please help take a look. Thanks.
Attachment #8607440 - Flags: review?(alive)
Comment on attachment 8607440 [details] [review]
[gaia] luke-chang:1166214_basemodule_support_subdirectory > mozilla-b2g:master

r=me, thanks for doing this!
Attachment #8607440 - Flags: review?(alive) → review+
Alive, Thanks for reviewing.
Status: NEW → ASSIGNED
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#1LtnkXuqQ26paSy69mcVvQ

The pull request failed to pass integration tests. It could not be landed, please try again.
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#ENqAiF6TTqy60lh1pArbAQ

The pull request failed to pass integration tests. It could not be landed, please try again.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: