1166243 - XPCShellEnvironment.cpp and XPCShellImpl.cpp are using __DATE__ and __TIME__

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Mike Hommey [:glandium]]

Both for the essentially the same code:

in the former:

static bool
BuildDate(JSContext *cx, unsigned argc, JS::Value *vp)
{
    JS::CallArgs args = JS::CallArgsFromVp(argc, vp);
    fprintf(stdout, "built on %s at %s\n", __DATE__, __TIME__);
    args.rval().setUndefined();
    return true;
}

in the latter:
static bool
BuildDate(JSContext* cx, unsigned argc, jsval* vp)
{
    CallArgs args = CallArgsFromVp(argc, vp);
    fprintf(gOutFile, "built on %s at %s\n", __DATE__, __TIME__);
    args.rval().setUndefined();
    return true;
}

This prevents reproducible builds. Is there a reason this is needed instead of using the buildid we're using for everything else?

Comment 1

[(Away)]

Looks like dead code to me. https://dxr.mozilla.org/mozilla-central/search?q=regexp%3A\WBuildDate

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

It's exposed to JS as a build() function.

Comment 3

[(Away)]

And does anyone call it?

Comment 4

[Mike Hommey [:glandium]]

js.cpp has the same code, too.

Comment 5

[Mike Hommey [:glandium]]

Come to think of it, the usefulness of these functions is questionable: they don't even return anything, they only print out the build time. Which in itself is not exactly a useful information. Is it a build of code from that day, or a later build of older code? How about removing this entirely?

ni? bholley for xpcshell and jorendorf for js shell.

Comment 6

[Bobby Holley (:bholley)]

Happy to get rid of it if it doesn't break anything.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Remove build() function from js and xpc shells

Comment 8

[Bobby Holley (:bholley)]

Comment on attachment 8610922 [details] [diff] [review]
Remove build() function from js and xpc shells

Review of attachment 8610922 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this might be useful if you have an xpcshell binary sitting around and want to know how old it is? I guess that still doesn't tell you all that much.

Comment 9

[Mike Hommey [:glandium]]

The file date is presumably giving as much information :)

Comment 10

[Eric Faust [:efaust]]

Comment on attachment 8610922 [details] [diff] [review]
Remove build() function from js and xpc shells

Review of attachment 8610922 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review as per request on IRC.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c021a5e9721c

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c021a5e9721c