1166278 - Support producing blob free full system zip

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[:gerard-majax]

We want a new makefile target: blobfree.
This will produce a zip file composed of:
 - a zip ready with all the partitions ready but not as images files (BOOT, RECOVERY and SYSTEM directories)
 - a devices.json file describing supported devices:
   - with adb properties and fastboot variables to read from and assert support in live
 - recovery fstab to have partition/images mapping
 - dt.img if needed
 - blobs to system mapping, inspired from what is produced by extract-files.sh

We will rely (for now at least) on fully redistribuable kernel and device tree. All other blobs can be pulled out of a living device.

Comment 1

[:gerard-majax]

Attachment: Gonk-misc PR

Comment 2

[:gerard-majax]

Comment on attachment 8609253 [details] [review]
Gonk-misc PR

This will be activated by the PR available on bug 1166279

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 8609253 [details] [review]
Gonk-misc PR

Looks fine to me, but I didn't look closely at details.

Comment 4

[Dave Hylands [:dhylands]]

Comment on attachment 8609253 [details] [review]
Gonk-misc PR

r=me with issues addressed. Mostly minor. My biggest concern was command line length for some of the for loops.

Comment 5

[:gerard-majax]

Dave, thanks for sharing your concern. All the for loop concerned are now while loop and should not expose this :)

Do you mind giving it a second look to make sure none slipped through ? Thanks!

Comment 6

[Dave Hylands [:dhylands]]

I added a couple more comments on github.

Comment 7

[:gerard-majax]

(In reply to Dave Hylands [:dhylands] from comment #6)
> I added a couple more comments on github.

Thanks, I've fixed those. I would not mind a another round if you think we need.

Comment 8

[Dave Hylands [:dhylands]]

lgtm

Comment 9

[:gerard-majax]

So far I have been able to produce multiple blobfree distribution that succeeded in morphing my Z3 running Android to a Z3 running B2G. I'll give it a couple of try again to make sure nothing slips through and I'll land this soon.

Comment 10

[:gerard-majax]

After testing again it's all good.

Comment 11

[:gerard-majax]

https://github.com/mozilla-b2g/gonk-misc/commit/3477513bcd385571aa01c0d074849e35bd5e2376

Comment 12

[:gerard-majax]

Chris, do you think this should deserve documentation on MDN?

Comment 13

[Chris Mills [:cmills]]

Yes, I think so.

So is this just a new make option? Would it go in here?

https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/make_options_reference

Comment 14

[:gerard-majax]

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #13)
> Yes, I think so.
> 
> So is this just a new make option?

Yes that's a new make target

> Would it go in here?
> 
> https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/
> make_options_reference

I don't think so, it's not a Gaia-level one but it's in gonk-misc, so intended to be called from build.sh, as |./build.sh blobfree|.

Comment 15

[Chris Mills [:cmills]]

(In reply to Alexandre LISSY :gerard-majax from comment #14)
> I don't think so, it's not a Gaia-level one but it's in gonk-misc, so
> intended to be called from build.sh, as |./build.sh blobfree|.

Oh, I'm sorry, I'm getting confused. So we could cover it in here:

https://developer.mozilla.org/en-US/Firefox_OS/Building#Building_Boot_to_Gecko

I have had a go at documenting it here:

https://developer.mozilla.org/en-US/Firefox_OS/Building#Building_a_blob_free_full_system_zip

Can you have a look and let me know if the wording is ok? I wasn't really sure of the purpose of this build type, so I basically just guessed.