Closed Bug 1166278 Opened 5 years ago Closed 5 years ago

Support producing blob free full system zip

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S14 (12june)

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Whiteboard: [spark][systemsfe])

Attachments

(1 file)

49 bytes, text/x-github-pull-request
dhylands
: review+
fabrice
: feedback+
Details | Review
We want a new makefile target: blobfree.
This will produce a zip file composed of:
 - a zip ready with all the partitions ready but not as images files (BOOT, RECOVERY and SYSTEM directories)
 - a devices.json file describing supported devices:
   - with adb properties and fastboot variables to read from and assert support in live
 - recovery fstab to have partition/images mapping
 - dt.img if needed
 - blobs to system mapping, inspired from what is produced by extract-files.sh

We will rely (for now at least) on fully redistribuable kernel and device tree. All other blobs can be pulled out of a living device.
Blocks: 1166279
Attached file Gonk-misc PR
Comment on attachment 8609253 [details] [review]
Gonk-misc PR

This will be activated by the PR available on bug 1166279
Attachment #8609253 - Flags: review?(dhylands)
Attachment #8609253 - Flags: feedback?(fabrice)
Comment on attachment 8609253 [details] [review]
Gonk-misc PR

Looks fine to me, but I didn't look closely at details.
Attachment #8609253 - Flags: feedback?(fabrice) → feedback+
Comment on attachment 8609253 [details] [review]
Gonk-misc PR

r=me with issues addressed. Mostly minor. My biggest concern was command line length for some of the for loops.
Attachment #8609253 - Flags: review?(dhylands) → review+
Dave, thanks for sharing your concern. All the for loop concerned are now while loop and should not expose this :)

Do you mind giving it a second look to make sure none slipped through ? Thanks!
Flags: needinfo?(dhylands)
I added a couple more comments on github.
Flags: needinfo?(dhylands)
Target Milestone: --- → 2.2 S13 (29may)
(In reply to Dave Hylands [:dhylands] from comment #6)
> I added a couple more comments on github.

Thanks, I've fixed those. I would not mind a another round if you think we need.
Flags: needinfo?(dhylands)
lgtm
Flags: needinfo?(dhylands)
Target Milestone: 2.2 S13 (29may) → 2.2 S14 (12june)
So far I have been able to produce multiple blobfree distribution that succeeded in morphing my Z3 running Android to a Z3 running B2G. I'll give it a couple of try again to make sure nothing slips through and I'll land this soon.
After testing again it's all good.
https://github.com/mozilla-b2g/gonk-misc/commit/3477513bcd385571aa01c0d074849e35bd5e2376
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Chris, do you think this should deserve documentation on MDN?
Flags: needinfo?(cmills)
Yes, I think so.

So is this just a new make option? Would it go in here?

https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/make_options_reference
Flags: needinfo?(cmills)
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #13)
> Yes, I think so.
> 
> So is this just a new make option?

Yes that's a new make target

> Would it go in here?
> 
> https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/
> make_options_reference

I don't think so, it's not a Gaia-level one but it's in gonk-misc, so intended to be called from build.sh, as |./build.sh blobfree|.
(In reply to Alexandre LISSY :gerard-majax from comment #14)
> I don't think so, it's not a Gaia-level one but it's in gonk-misc, so
> intended to be called from build.sh, as |./build.sh blobfree|.

Oh, I'm sorry, I'm getting confused. So we could cover it in here:

https://developer.mozilla.org/en-US/Firefox_OS/Building#Building_Boot_to_Gecko

I have had a go at documenting it here:

https://developer.mozilla.org/en-US/Firefox_OS/Building#Building_a_blob_free_full_system_zip

Can you have a look and let me know if the wording is ok? I wasn't really sure of the purpose of this build type, so I basically just guessed.
Blocks: 1172912
You need to log in before you can comment on or make changes to this bug.