1166325 - valgrind mozconfigs should use same optimization settings as our normal builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nathan Froyd [:froydnj]]

I have a patchset that compiles cleanly on our linux64 builders, but errors out with an uninitialized variable warning/error on our valgrind build.  It's worth noting that our linux64 builders *do* issue a similar warning, but in the valgrind case, it's a -Wuninitialized warning (which is an error), and in the linux64 case, it's a -Wmaybe-uninitialized warning (not a hard error due to false positives).

My best guess is that this is caused by the different optimization settings; our normal linux64 builds default to -Os deep in the bowels of configure, whereas our valgrind builds use -O:

http://mxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/linux64/valgrind#8

I think the valgrind builds should be using the same optimization settings as our normal builds, so that we avoid running into problems like this.

Comment 1

[Nathan Froyd [:froydnj]]

(I should also note that the error comes from a part of the code that I didn't touch, which makes it doubly frustrating.)

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: use -Os in valgrind mozconfigs to match the default optimization settings

This patch solves my problem, at least.  I think it makes more sense to have
matching optimization settings between valgrind and the default builds.

I have no ideas on how to maintain the optimization settings in sync, though...

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8607631 [details] [diff] [review]
use -Os in valgrind mozconfigs to match the default optimization settings

Review of attachment 8607631 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed on IRC, these optimization flags appear to be the defaults for linux-gcc nowadays, so I think we can safely remove these lines entirely:
https://hg.mozilla.org/mozilla-central/annotate/ac277e615f8f/configure.in#l2132

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: use default optimization settings in valgrind mozconfigs

Hooray for deleting code rather than changing it.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8182dab4c18

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a8182dab4c18