1166337 - Ignore *@users.noreply.github.com returned from GitHub

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect, P2)

Description

[Dylan Hardison [:dylan] (he/him)]

We already ignore unverified email addresses, so we should ignore *@users.noreply.github.com as well.

If GitHub returns ONLY a noreply account, we will fail with a specific error explaining to the user that this is not acceptable.

(Anonymity is fine, but the noreply aspect is what is not acceptable.)

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1166337_1.patch

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8611603 [details] [diff] [review]
1166337_1.patch

Actually, dkl makes more sense as he's seen this code. my bad.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8611603 [details] [diff] [review]
1166337_1.patch

Review of attachment 8611603 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/GitHubAuth/lib/Login.pm
@@ +145,5 @@
> +        if (@verified_emails) {
> +            return { failure => AUTH_ERROR, user_error => 'github_no_reply_email' };
> +        }
> +        else {
> +            return { failure => AUTH_ERROR, user_error => 'github_no_emails' };

See comment about using single 'github_no_emails' error for user-error-errors.html.tmpl.

::: extensions/GitHubAuth/template/en/default/hook/global/user-error-errors.html.tmpl
@@ +11,5 @@
>    has no verified email addresses or [% terms.Bugzilla %] is not authorized to see them.
>  
> +[% ELSIF error == "github_no_reply_email" %]
> +  Your GitHub account cannot be used because [% terms.Bugzilla %] cannot see any
> +  email addresses, except for [% noreply_email FILTER html %]. GitHub noreply

noreply_email not set to any value in the code. Instead of having a separate error, I would
just combine with 'github_no_emails' and mention in the error text that noreply emails are not acceptable.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1166337_2.patch

With simplified error handling per last review.

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8621397 [details] [diff] [review]
1166337_2.patch

Review of attachment 8621397 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: extensions/GitHubAuth/template/en/default/hook/global/user-error-errors.html.tmpl
@@ +7,5 @@
>    #%]
>  
>  [% IF error == "github_no_emails" %]
> +  Your GitHub account cannot be used because [% terms.Bugzilla %] cannot see any useable email addresses. Your GitHub account
> +  may have no verified email addresses, [% terms.Bugzilla %] is not authorized to see them, or you have reply-able email addresses.

s/reply-able/non-reply-able/

Comment 6

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   cadc7a6..061328f  master -> master