Closed Bug 1166344 Opened 5 years ago Closed 5 years ago

[rule view] Filter styles does not match the actual property value displayed in the computed list

Categories

(DevTools :: Inspector, defect)

40 Branch
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: bgrins, Assigned: gl)

References

Details

Attachments

(1 file, 2 obsolete files)

Noticed this today:

Open https://bgrins.github.io/devtools-demos/
Try searching in the rules view for: "background-color: #F3F3F3"
Nothing matches
Try searching in the rules view for: "background-color: 2"
It matches the 'computed' property: background-color: #F3F3F3
Assignee: nobody → gabriel.luong
Summary: Styles filter for background-color not matching hex value → [rule view] Filter rules does not match the actual property value displayed in the computed list
Summary: [rule view] Filter rules does not match the actual property value displayed in the computed list → [rule view] Filter styles does not match the actual property value displayed in the computed list
Attached patch 1166344.patch (obsolete) — Splinter Review
Status: NEW → ASSIGNED
Comment on attachment 8608371 [details] [diff] [review]
1166344.patch

Review of attachment 8608371 [details] [diff] [review]:
-----------------------------------------------------------------

Good find!  As discussed, I'd like to move the DOM traversal elsewhere and store this as a property we can reference directly on the computed object. Either immediately after where the output parser called, or as a getter created when the computed object is created.  Whatever you think is better
Attachment #8608371 - Flags: review?(bgrinstead)
Attached patch 1166344.patch (obsolete) — Splinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f4d9942e48f
Attachment #8608371 - Attachment is obsolete: true
Attachment #8609012 - Flags: review?(bgrinstead)
It was better to store the parsed value in updateComputed to account for when the computed list is updated from a property change.
Comment on attachment 8609012 [details] [diff] [review]
1166344.patch

Review of attachment 8609012 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!  Please update the commit message to say what the patch is doing instead of restating the problem
Attachment #8609012 - Flags: review?(bgrinstead) → review+
Attached patch 1166344.patchSplinter Review
Attachment #8609012 - Attachment is obsolete: true
Attachment #8609025 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ac0bd7ff30d8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
QA Whiteboard: [good first verify]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.