Closed
Bug 1166344
Opened 9 years ago
Closed 9 years ago
[rule view] Filter styles does not match the actual property value displayed in the computed list
Categories
(DevTools :: Inspector, defect)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: bgrins, Assigned: gl)
References
Details
Attachments
(1 file, 2 obsolete files)
|
5.27 KB,
patch
|
gl
:
review+
|
Details | Diff | Splinter Review |
Noticed this today: Open https://bgrins.github.io/devtools-demos/ Try searching in the rules view for: "background-color: #F3F3F3" Nothing matches Try searching in the rules view for: "background-color: 2" It matches the 'computed' property: background-color: #F3F3F3
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → gabriel.luong
|
|
Assignee | |
Updated•9 years ago
|
Summary: Styles filter for background-color not matching hex value → [rule view] Filter rules does not match the actual property value displayed in the computed list
|
|
Assignee | |
Updated•9 years ago
|
Summary: [rule view] Filter rules does not match the actual property value displayed in the computed list → [rule view] Filter styles does not match the actual property value displayed in the computed list
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8608371 [details] [diff] [review] 1166344.patch https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea827a6e7bf7
Attachment #8608371 -
Flags: review?(bgrinstead)
|
Reporter | |
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 3•9 years ago
|
||
Comment on attachment 8608371 [details] [diff] [review] 1166344.patch Review of attachment 8608371 [details] [diff] [review]: ----------------------------------------------------------------- Good find! As discussed, I'd like to move the DOM traversal elsewhere and store this as a property we can reference directly on the computed object. Either immediately after where the output parser called, or as a getter created when the computed object is created. Whatever you think is better
Attachment #8608371 -
Flags: review?(bgrinstead)
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f4d9942e48f
Attachment #8608371 -
Attachment is obsolete: true
Attachment #8609012 -
Flags: review?(bgrinstead)
|
|
Assignee | |
Comment 5•9 years ago
|
||
It was better to store the parsed value in updateComputed to account for when the computed list is updated from a property change.
|
|
Reporter | |
Comment 6•9 years ago
|
||
Comment on attachment 8609012 [details] [diff] [review] 1166344.patch Review of attachment 8609012 [details] [diff] [review]: ----------------------------------------------------------------- Nice! Please update the commit message to say what the patch is doing instead of restating the problem
Attachment #8609012 -
Flags: review?(bgrinstead) → review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
Attachment #8609012 -
Attachment is obsolete: true
Attachment #8609025 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ac0bd7ff30d8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
|
||
Updated•9 years ago
|
QA Whiteboard: [good first verify]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•