Closed Bug 1166355 Opened 5 years ago Closed 9 months ago

[mozlog] HTML formatter generates wrong link for the gecko revision to hg.mozilla.org

Categories

(Testing :: Mozbase, defect)

38 Branch
defect
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: whimboo, Assigned: asfiyab95, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

The Gecko revision as included in the HTML report references the wrong URL and ends up in a 404 at the moment. 

Currently:  https://hg.mozilla.org/mozilla-central/35918b0441b4
Expected: https://hg.mozilla.org/mozilla-central/rev/35918b0441b4

As it looks by this code the 'rev/' part is not included when generating the link:

http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozlog/mozlog/structured/formatters/html/html.py#70

Hi, I would like to solve this bug.

I have made the change in the code. How can I check if the correct URL is being generated?

(In reply to asfiyab95 from comment #3)

I have made the change in the code. How can I check if the correct URL is being generated?

Flags: needinfo?(james)

YOu should be able to run a testsuite using something like ./mach wpt --log-html log.html testing/web-platform/infrastructure and then open the log.html file in the browser and see if the link leads to a real page.

Flags: needinfo?(james)

Hi, My name is Ana and I am an outreachy applicant. Can I work on this issue?

Hi Ana, I am still working on it!

No worries @asfiyab95 :) I was looking for an issue to work on.

HTML formatter generates correct link

The HTML formatter now references the correct link and does not produce a 404 error

Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/615d38401d49
HTML formatter generates correct link for the gecko revision to hg.mozilla.org r=jgraham
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/8963bca25d1a
HTML formatter generates correct link for the gecko revision to hg.mozilla.org r=jgraham
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → asfiyab95
Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.