Closed Bug 1166392 Opened 5 years ago Closed 5 years ago

Reader View type options are not localized anymore

Categories

(Firefox for Android :: Reader View, defect)

38 Branch
All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox38 --- wontfix
firefox38.0.5 + verified
firefox39 + verified
firefox40 + fixed
firefox41 + fixed
fennec 38+ ---

People

(Reporter: tchevalier, Assigned: Margaret)

Details

Attachments

(2 files, 1 obsolete file)

Not sure since when, but 41 (current Nightly) to 38 (latest release) are affected.

I guess it's broken since we moved strings under /toolkit
Probably needs to pick them up as overloads in mobile/android/locales/jar.mn
tracking-fennec: --- → ?
[Tracking Requested - why for this release]: regression in key feature for 38.0.5
tracking-fennec: ? → 38+
OS: Unspecified → Android
Hardware: Unspecified → All
Version: unspecified → Firefox 38
So, aboutReader.properties is a toolkit file now:
http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/aboutReader.properties

Looking for examples of similar toolkit pages that include strings, I see us including/overriding aboutSupport.dtd here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/locales/jar.mn#62
http://mxr.mozilla.org/mozilla-central/source/mobile/android/locales/jar.mn#87

I assume I just need to do the same thing for aboutReader.properties? I'm confused about why we need to do this. Do we always need to explicitly include toolkit strings like this?
Flags: needinfo?(l10n)
Flags: needinfo?(francesco.lodolo)
Right, all toolkit strings are explicitly hooked up for android in the jar.mn. That's how we reduced the impact of localizations on the apk size such that we can ship all the things we're shipping.
Flags: needinfo?(l10n)
Flags: needinfo?(francesco.lodolo)
Assignee: nobody → margaret.leibovic
Attachment #8608937 - Flags: review?(mark.finkle)
Oops, wrong version.
Attachment #8608937 - Attachment is obsolete: true
Attachment #8608937 - Flags: review?(mark.finkle)
Attachment #8608938 - Flags: review?(mark.finkle)
Attachment #8608938 - Flags: review?(mark.finkle) → review+
Comment on attachment 8608938 [details] [diff] [review]
Include about:reader strings on Android

Approval Request Comment
[Feature/regressing bug #]: bug 793920 (moving reader view strings to toolkit)
[User impact if declined]: reader view controls won't be localized
[Describe test coverage new/current, TreeHerder]: no automated tests, verified that this builds properly locally, but I didn't test with a multi-locale build
[Risks and why]: low-risk, adds missing locale file to Android builds
[String/UUID change made/needed]: none (although this affects localized strings, it should just update our build to pull in the correct toolkit strings)
Attachment #8608938 - Flags: approval-mozilla-release?
Attachment #8608938 - Flags: approval-mozilla-beta?
Attachment #8608938 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/cf88ba99f9fd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Attachment #8608938 - Flags: approval-mozilla-release?
Attachment #8608938 - Flags: approval-mozilla-release+
Attachment #8608938 - Flags: approval-mozilla-beta?
Attachment #8608938 - Flags: approval-mozilla-beta+
Attachment #8608938 - Flags: approval-mozilla-aurora?
Attachment #8608938 - Flags: approval-mozilla-aurora+
Tested with:
Build: Firefox for Android 41.0a1 (2015-05-27)
Testing with following locales:

da, fi, nl, nb-no,pt-BR, sv-se - reader view controls are not translated
cs, de, es-ES, fr, ja - "Sans-serif" and "Sans" not translated
ko, it, pl, pt-PT, ru, sk, zh-CN, zh-TW - all controls are translated
The reader view type options are localized on 38.0.5 RC build 1. Tested on da, nl, fr, it, pl
Verifying as fixed on 35.0.5
Verified as fixed on Firefox 39.0b2.
You need to log in before you can comment on or make changes to this bug.