1166392 - Reader View type options are not localized anymore

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Théo Chevalier]

Attachment: Firefox for Android 38, French

Not sure since when, but 41 (current Nightly) to 38 (latest release) are affected.

I guess it's broken since we moved strings under /toolkit

Comment 1

[Axel Hecht [:Pike]]

Probably needs to pick them up as overloads in mobile/android/locales/jar.mn

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: regression in key feature for 38.0.5

Comment 3

[:Margaret Leibovic]

So, aboutReader.properties is a toolkit file now:
http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/aboutReader.properties

Looking for examples of similar toolkit pages that include strings, I see us including/overriding aboutSupport.dtd here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/locales/jar.mn#62
http://mxr.mozilla.org/mozilla-central/source/mobile/android/locales/jar.mn#87

I assume I just need to do the same thing for aboutReader.properties? I'm confused about why we need to do this. Do we always need to explicitly include toolkit strings like this?

Comment 4

[Axel Hecht [:Pike]]

Right, all toolkit strings are explicitly hooked up for android in the jar.mn. That's how we reduced the impact of localizations on the apk size such that we can ship all the things we're shipping.

Comment 5

[:Margaret Leibovic]

Attachment: Include about:reader strings on Android

Comment 6

[:Margaret Leibovic]

Attachment: Include about:reader strings on Android

Oops, wrong version.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cf88ba99f9fd

Comment 8

[:Margaret Leibovic]

Comment on attachment 8608938 [details] [diff] [review]
Include about:reader strings on Android

Approval Request Comment
[Feature/regressing bug #]: bug 793920 (moving reader view strings to toolkit)
[User impact if declined]: reader view controls won't be localized
[Describe test coverage new/current, TreeHerder]: no automated tests, verified that this builds properly locally, but I didn't test with a multi-locale build
[Risks and why]: low-risk, adds missing locale file to Android builds
[String/UUID change made/needed]: none (although this affects localized strings, it should just update our build to pull in the correct toolkit strings)

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Tracking for the reasons in comment #2.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cf88ba99f9fd

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c0a779c57c3a

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce664a21fda4

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/a468d1edeac8

Comment 14

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Build: Firefox for Android 41.0a1 (2015-05-27)
Testing with following locales:

da, fi, nl, nb-no,pt-BR, sv-se - reader view controls are not translated
cs, de, es-ES, fr, ja - "Sans-serif" and "Sans" not translated
ko, it, pl, pt-PT, ru, sk, zh-CN, zh-TW - all controls are translated

Comment 15

[Catalin Suciu [:csuciu]]

The reader view type options are localized on 38.0.5 RC build 1. Tested on da, nl, fr, it, pl
Verifying as fixed on 35.0.5

Comment 16

[Catalin Suciu [:csuciu]]

Verified as fixed on Firefox 39.0b2.