troubleshooting account, identity information is missing

RESOLVED FIXED in Thunderbird 41.0

Status

Thunderbird
Mail Window Front End
--
enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Dan Pernokis, Assigned: aceman)

Tracking

31 Branch
Thunderbird 41.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

7.46 KB, patch
aceman
: review+
Details | Diff | Splinter Review
(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150513174244

Steps to reproduce:

Run Thunderbird's TROUBLESHOOTING page and click "Include Account Names".  Then go to the MAIL AND NEWS ACCOUNTS section.


Actual results:

The Account Names turn on as one would expect for each account, but there is no info about the entities.  For accounts with multiple entities, all we see is a repetitive list of mail servers and, under status, "false" for all except first entity (which says "true").  



Expected results:

Since I clicked "Include Account Names", I would expect to see the Entity names as well.  Otherwise:
If they all use same server, then why repeat the same info?
If they use different servers, then how do I know who uses what?

[[ If anyone is going to tackle this, I would suggest a second checkbox to "Include Entity Names" so accounts can be shown (as now) without compromising actual email user names. ]]
Component: Untriaged → Mail Window Front End
Summary: troubleshooting account entity info missing → troubleshooting account, identity information is missing
(Assignee)

Comment 1

2 years ago
Yeah, this could be useful.
Assignee: nobody → acelists
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → All
(Assignee)

Comment 2

2 years ago
Created attachment 8609855 [details] [diff] [review]
patch

Would this work?
Attachment #8609855 - Flags: review?(mkmelin+mozilla)
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 3

2 years ago
Ace, if you're talking to me, I don't know the code to say definitely yes, but based on the logic flow I think I see, then I think it probably does.

(Is any of this code temporarily installable for me to test?)

Comment 4

2 years ago
Comment on attachment 8609855 [details] [diff] [review]
patch

Review of attachment 8609855 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good if you get rid of the duplicated info.

::: mail/components/about-support/content/aboutSupport.xhtml
@@ +227,5 @@
> +            </th>
> +
> +            <th class="data-private">
> +              &aboutSupport.identityEmail;
> +            </th>

I think this isn't needed. All we need is (or should be) in the identityName

::: mail/locales/en-US/chrome/messenger/aboutSupportMail.dtd
@@ +16,4 @@
>  <!ENTITY aboutSupport.accountsConnSecurity "Connection security">
>  <!ENTITY aboutSupport.accountsAuthMethod "Authentication method">
>  <!ENTITY aboutSupport.accountsDefault "Default?">
> +<!ENTITY aboutSupport.identityName "Identity name">

... and then this should just be "Identity"
Attachment #8609855 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 5

2 years ago
Yeah, I made this having bug 318495 in mind. In its state state at the time, identityName does not necessarily contain the email.
Depends on: 318495
(Assignee)

Comment 6

2 years ago
Created attachment 8621238 [details] [diff] [review]
patch v1.1

On the other hand, the user should have enough hints from the identityName alone.
Attachment #8609855 - Attachment is obsolete: true
Attachment #8621238 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Reporter)

Comment 7

2 years ago
Thanks, Ace!

Comment 8

2 years ago
https://hg.mozilla.org/comm-central/rev/8f8d9edfa43e

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
(Reporter)

Comment 9

2 years ago
Any idea when (in the calendar) this new feature will be released?  (We're currently at TB 38, and TB 41 sounds a long way off.)
(Assignee)

Comment 10

2 years ago
Actually TB41 is just around the corner (it is in beta channel now, if you wanted to try it). However, that will never be released as stable version. The next stable version released to users will be TB 45. That one is about 30 weeks away.
Severity: normal → enhancement
You need to log in before you can comment on or make changes to this bug.