Closed
Bug 1166494
Opened 9 years ago
Closed 9 years ago
Re-add all metadata for markers
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox40 verified, firefox41 fixed)
VERIFIED
FIXED
Firefox 41
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
2.71 KB,
patch
|
vporof
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
console timestamp markers (time cause) style markers (restyle hints)
Summary: Readd all marker fields → Read all marker fields
Assignee | ||
Comment 1•9 years ago
|
||
Hastily made ticket during a meeting -- to clarify, this is to display all the meta we have currently for markers
Summary: Read all marker fields → Re-add all metadata for markers
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
This won't work until bug 1162662 lands, but this is the idea -- re-adds console timestamp's "cause" if it exists, and the new style markers' "Restyle Hint" property.
Attachment #8608163 -
Flags: review?(vporof)
Updated•9 years ago
|
Attachment #8608163 -
Flags: review?(vporof) → review+
Assignee | ||
Updated•9 years ago
|
Blocks: perf-40-uplifts
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Blocks: perf-tool-v2
Assignee | ||
Comment 3•9 years ago
|
||
one chunk failed during landing, but here's part 1 part 1 https://hg.mozilla.org/integration/fx-team/rev/52be40f91144
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 4•9 years ago
|
||
part 2 https://hg.mozilla.org/integration/fx-team/rev/8ca0d6de9f02
Assignee | ||
Comment 5•9 years ago
|
||
Something terrible happened with this patch. Landing a piece from bug 1162662 that should've been here too to fix oranges on fx-team. https://hg.mozilla.org/integration/fx-team/rev/63aad1dd5de1
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/52be40f91144 https://hg.mozilla.org/mozilla-central/rev/8ca0d6de9f02 https://hg.mozilla.org/mozilla-central/rev/63aad1dd5de1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Comment 7•9 years ago
|
||
Not 100% sure, but this looks like it could use verification after uplift. ni? jsantell for STR to verify
Flags: qe-verify+
Flags: needinfo?(jsantell)
Assignee | ||
Comment 8•9 years ago
|
||
STR: Restyle Markers * Record a new profile (go to yahoo.com, and record for 3 seconds) * Find a purple "Recalculate Styles" marker and click on it in the waterfall view * The details view on the right should have listed a "Restyle Hint" for this marker Timestamp Markers * Open the performance tool with split console view, start recording. * in the console, type `console.timeStamp("GO!")` * stop recording * In the recording results, find the timestamp marker in the waterfall view. click on it to open the details view * Ensure it has a label field with "GO!"
Flags: needinfo?(jsantell)
Comment 9•9 years ago
|
||
Comment on attachment 8608163 [details] [diff] [review] 1166494-marker-meta.patch Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8608163 -
Flags: approval-mozilla-aurora?
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/500cd2821bce https://hg.mozilla.org/releases/mozilla-aurora/rev/bdcdadeb595c https://hg.mozilla.org/releases/mozilla-aurora/rev/f00b5164da00
status-firefox40:
--- → fixed
Comment 11•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 12•9 years ago
|
||
Comment on attachment 8608163 [details] [diff] [review] 1166494-marker-meta.patch Change approved to skip one train as part of the spring campaign.
Attachment #8608163 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•9 years ago
|
||
Verified fixed on Aurora 40.0a2 (2015-06-09) using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5, using the steps from Comment 8 (thanks Jordan!). The "Label" and "Restyle Hint" fields are now displayed in the sidebar for eligible markers.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•