Closed Bug 1166494 Opened 5 years ago Closed 5 years ago
Re-add all metadata for markers
console timestamp markers (time cause) style markers (restyle hints)
Summary: Readd all marker fields → Read all marker fields
Hastily made ticket during a meeting -- to clarify, this is to display all the meta we have currently for markers
Summary: Read all marker fields → Re-add all metadata for markers
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
This won't work until bug 1162662 lands, but this is the idea -- re-adds console timestamp's "cause" if it exists, and the new style markers' "Restyle Hint" property.
Attachment #8608163 - Flags: review?(vporof)
Attachment #8608163 - Flags: review?(vporof) → review+
one chunk failed during landing, but here's part 1 part 1 https://hg.mozilla.org/integration/fx-team/rev/52be40f91144
Something terrible happened with this patch. Landing a piece from bug 1162662 that should've been here too to fix oranges on fx-team. https://hg.mozilla.org/integration/fx-team/rev/63aad1dd5de1
Not 100% sure, but this looks like it could use verification after uplift. ni? jsantell for STR to verify
STR: Restyle Markers * Record a new profile (go to yahoo.com, and record for 3 seconds) * Find a purple "Recalculate Styles" marker and click on it in the waterfall view * The details view on the right should have listed a "Restyle Hint" for this marker Timestamp Markers * Open the performance tool with split console view, start recording. * in the console, type `console.timeStamp("GO!")` * stop recording * In the recording results, find the timestamp marker in the waterfall view. click on it to open the details view * Ensure it has a label field with "GO!"
Comment on attachment 8608163 [details] [diff] [review] 1166494-marker-meta.patch Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8608163 - Flags: approval-mozilla-aurora?
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment on attachment 8608163 [details] [diff] [review] 1166494-marker-meta.patch Change approved to skip one train as part of the spring campaign.
Attachment #8608163 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Aurora 40.0a2 (2015-06-09) using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5, using the steps from Comment 8 (thanks Jordan!). The "Label" and "Restyle Hint" fields are now displayed in the sidebar for eligible markers.
You need to log in before you can comment on or make changes to this bug.