If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use the default devtools monospace font for text nodes in the markup view

RESOLVED FIXED in Firefox 41

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

40 Branch
Firefox 41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
Now that we are auto expanding the contents of nodes (bug 892935) and collapsing whitespace in the view (bug 1046803), we should update the styles to make it look nicer.  We should use the default devtools-monospace font (which changes per OS)
Probably worth adding yourself as mentor and marking as a [good ... bug], unless you intended to tackle it yourself.
(Assignee)

Comment 2

2 years ago
I thought the tricky part was going to be making sure the sizing is right across all OSes.  I needed to do some exploring to figure out exactly what guidance I would give and in the process have a pretty much working patch, so I'll just take it
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
(Assignee)

Comment 3

2 years ago
Created attachment 8608260 [details]
markup-font-windows.png

screenshot of windows with and without the font applied
(Assignee)

Comment 4

2 years ago
Created attachment 8608262 [details]
markup-font-osx.png

screenshot of osx with and without the font applied
(Assignee)

Comment 5

2 years ago
linux just uses the default monospace font for devtools-monospace, so it doesn't end up looking any different
(Assignee)

Comment 6

2 years ago
Created attachment 8608265 [details] [diff] [review]
markup-font.patch

What do you think?  Just resets the font to inherit.  While I was in there I noticed we weren't doing that comment thing that's done throughout the markup-view templates for inline-block children, so added that too
Attachment #8608265 - Flags: review?(pbrosset)
Comment on attachment 8608265 [details] [diff] [review]
markup-font.patch

Review of attachment 8608265 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not seeing a huge difference, but I trust your eye for details. I've applied the patch and it looked good locally anyway, and the code changes are fine.
Attachment #8608265 - Flags: review?(pbrosset) → review+
(Assignee)

Comment 8

2 years ago
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1d9e7176560
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 9

2 years ago
remote:   https://hg.mozilla.org/integration/fx-team/rev/e1d9a7d1d059
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e1d9a7d1d059
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.