1166528 - Include app state in lookup dropdown

Status: VERIFIED FIXED

(Marketplace Graveyard :: Admin Tools, enhancement, P3)

Description

[:Harald Kirschner :digitarald]

We have *a lot* of deleted and incomplete apps in lookup. The creative Lookup algorithm challenges the user by finding things in unexpected and unsorted ways [1]. Knowing which apps are actually live or pending review helps sorting through the cruft.

This is impacting staff's productive in supporting partners.

[1] Search for "Soundc", find 2 Soundclouds in position 7 and 8 and a random assortment containing "Sound" before.

Comment 1

[Andrew Williamson [:eviljeff]]

agreed.  its a lucky dip at the moment what you get first.  In the past I've thought colour coding the results would be cool.

Comment 2

[Lisa Brewster [:adora]]

And when you search for soundcloud (the full word), two of the three results are the same appid.  Crazy!

What if the background color of the appid was green for published, red for rejected, and gray for incomplete?

Comment 3

[Rob Hudson [:robhudson]]

(In reply to Lisa Brewster [:adora] from comment #2)
> And when you search for soundcloud (the full word), two of the three results
> are the same appid.  Crazy!

Yeah, we include translations of the app but show them as separate app results. Kinda funky.

> What if the background color of the appid was green for published, red for
> rejected, and gray for incomplete?

+1

Comment 4

[:Harald Kirschner :digitarald]

(In reply to Rob Hudson [:robhudson] from comment #3)
> (In reply to Lisa Brewster [:adora] from comment #2)
> > What if the background color of the appid was green for published, red for
> > rejected, and gray for incomplete?
> 
> +1

Yellow for in-review, purple for published but hidden. Double Rainbows all the way.

Comment 5

[Andrew Williamson [:eviljeff]]

there's also blocklisted and banned states (red would probably do); deleted (grey?); and disabled (which isn't a status but effectively overrides (most of) the other states (grey again?  A different colour?)

Comment 6

[Rob Hudson [:robhudson]]

Heh, definitely a paint the bike-shed type of bug, eh?

This is what I have currently in a branch and thought it looked pretty good:

+                &.status-public,
+                &.status-approved,
+                &.status-unlisted {
+                    background-color: $green;
+                    color: $white;
+                }
+                &.status-rejected,
+                &.status-blocked {
+                    background-color: $red;
+                    color: $white;
+                }
+                &.status-disabled,
+                &.status-incomplete {
+                    background-color: $gray;
+                    color: $white;
+                }
+                &.status-pending {
+                    background-color: $notice-yellow;
+                    color: $black;
+                }
+                &.status-deleted {
+                    background-color: $black;
+                    color: $white;
+                }

I also added a title attribute so you can hover on the ID and see "unlisted", e.g. If that all sounds fine I'll ship it.

Comment 7

[Andrew Williamson [:eviljeff]]

Sounds good. 
Is &.status-disabled what we refer to as disabled (i.e. user disabling) or the status integer represented by constant STATUS_DISABLED, now labelled as Banned (to distinguish from said user disabling).

Comment 8

[Rob Hudson [:robhudson]]

(In reply to Andrew Williamson [:eviljeff] from comment #7)
> Sounds good. 
> Is &.status-disabled what we refer to as disabled (i.e. user disabling) or
> the status integer represented by constant STATUS_DISABLED, now labelled as
> Banned (to distinguish from said user disabling).

It's banned. Disabled is a flag on the addons table and not a status.
See: https://github.com/mozilla/zamboni/blob/master/mkt/constants/base.py#L47-L57

But I think your point is that this should be with the rejected/blocked statuses and be red?

Comment 9

[Andrew Williamson [:eviljeff]]

(In reply to Rob Hudson [:robhudson] from comment #8)
> It's banned. Disabled is a flag on the addons table and not a status.
> See:
> https://github.com/mozilla/zamboni/blob/master/mkt/constants/base.py#L47-L57
> 
> But I think your point is that this should be with the rejected/blocked
> statuses and be red?

If its banned it should be red, yes.  
Ideally user disabling would be taken into account also though (showing a disabled app as green because its status was public before the developer disabled it could be confusing).

Comment 10

[Rob Hudson [:robhudson]]

Merged:
https://github.com/mozilla/zamboni/pull/3117

Comment 11

[Victor Carciu]

Verified as fixed : http://screencast.com/t/nOv7k1zxV