Closed
Bug 1166559
Opened 9 years ago
Closed 9 years ago
Documentation for marker information
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox40 fixed, firefox41 fixed)
RESOLVED
FIXED
Firefox 41
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file, 1 obsolete file)
4.84 KB,
patch
|
jsantell
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We should have documentation for what markers are, what they represent, possible attributes for each marker type, and what those attributes mean, and can be.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8607848 -
Flags: review?(nfitzgerald)
Comment 2•9 years ago
|
||
Comment on attachment 8607848 [details] [diff] [review] 1166559-marker-docs.patch Review of attachment 8607848 [details] [diff] [review]: ----------------------------------------------------------------- r=me w/ 80 column line wrapping for readability (like we do in js/src/doc)
Updated•9 years ago
|
Attachment #8607848 -
Flags: review?(nfitzgerald) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Capping lines at 80
Attachment #8607848 -
Attachment is obsolete: true
Attachment #8608350 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Whiteboard: [fixed-in-fx-team]
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fae02c56ffc5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
Blocks: perf-40-uplifts
Updated•9 years ago
|
Flags: qe-verify-
Comment 6•9 years ago
|
||
Comment on attachment 8608350 [details] [diff] [review] 1166559-marker-docs.patch Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8608350 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/5f877b17350f
status-firefox40:
--- → fixed
Comment 8•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 9•9 years ago
|
||
Comment on attachment 8608350 [details] [diff] [review] 1166559-marker-docs.patch Change approved to skip one train as part of the spring campaign.
Attachment #8608350 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•