1166575 - uninitialized variable error in dom/bluetooth/bluedroid/BluetoothHALInterface.cpp when building a debug B2G build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Cameron McCormack (:heycam)]

I'm running into a build error when trying to produce a debug B2G build.  Warnings-as-errors is turned on for dom/bluetooth/bluedroid/ and I end up with an error complaining about |name| in BluetoothHALInterface::GetRemoteDeviceProperty being undefined before being passed into get_remote_device_property.  This is with gcc 4.7.  I guess we should either just initialize it with a dummy value, or not actually compile that branch of the if statement since it's |&& false| anyway.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8607873 [details] [diff] [review]
patch

Review of attachment 8607873 [details] [diff] [review]:
-----------------------------------------------------------------

This code is mostly a placeholder and obviously unused. It's supposed to be removed during the next months. Anyway, thanks a lot for cleaning up!

::: dom/bluetooth/bluedroid/BluetoothHALInterface.cpp
@@ +640,4 @@
>  
>    if (NS_SUCCEEDED(Convert(aRemoteAddr, remoteAddr)) &&
>        false /* TODO: we don't support any values for aName currently */) {
> +    name = (bt_property_type_t) 0;  // to silence uninitialized variable warning

Please use C++'s static_cast<bt_property_type_t>.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d98d6c08d2fd

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d98d6c08d2fd