Closed Bug 1166577 Opened 5 years ago Closed 5 years ago

Cache API should bind sqlite parameters using names instead of indices

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(1 file)

Use named sqlite params in Cache API code. r=ehsan
24.45 KB, patch
ehsan
: review+
Details | Diff | Splinter Review 
Currently the Cache API sqlite code is written by binding parameters using an index value.  This is confusing and hard to maintain.  Lets bind by name instead.

I want to use bound names in bug 1166038, so block that bug.
The changes the vast majority over to named params.  I had to leave indexed based params for the bulk delete operation as the number of params is variable.

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=85c2914a3e03
Attachment #8607875 - Flags: review?(ehsan)
Attachment #8607875 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/34b535599229
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.