1166599 - [Presentation WebAPI] TCP presentation server malfunctions after it is non-manually closed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Junior [inactive]]

STR:
1. Let the server socket be closed non-manually
2. init the tcp presentation server again and create a device

Expected result:
create successfully

Actual result:
throws an exception

Comment 1

[Junior [inactive]]

Hello Honza,
I got trouble in |nsServerSocket|.
In a _xpcshell_ test, I'd like to simulate a server socket is dead by non-manually closed such as network down.
In other words, |aServerSocketListener.onStopListening| is called _not_ by |aServerSocket.close|.

Any ideas?
Thanks.

Comment 2

[Junior [inactive]]

Attachment: initDevices

WIP

init |_devices| correctly and remove the redundant |TCPPresentationServer.close|

Todo: to figure out a way to close server sockets non-manually

Comment 3

[Honza Bambas (:mayhemer)]

(In reply to Junior [:junior] from comment #1)
> Hello Honza,
> I got trouble in |nsServerSocket|.
> In a _xpcshell_ test, I'd like to simulate a server socket is dead by
> non-manually closed such as network down.
> In other words, |aServerSocketListener.onStopListening| is called _not_ by
> |aServerSocket.close|.
> 
> Any ideas?
> Thanks.

Not by hand.  I'm also not sure what you are trying to achieve.  I presume gracefully closing the socket (after which you get RST when trying to connect) is not what you want, right?

You could try up/down all interfaces the server is bound to, but this is not a question for me, rather ask some test harness folks.

Comment 4

[Honza Bambas (:mayhemer)]

BTW, google is probably your friend here ;)

Comment 5

[Junior [inactive]]

We found |aServerSocketListener.onStopListening| is called after netd says hello to b2g in booting up. Some problems occur for this case. So yes, I'd like to _not_ gracefully closing server socket.

Originally I guess there's some trick for doing this. For example, give a hint of offline as bug 1134596. I'll look around those possible tricks and try them later.

Comment 6

[Junior [inactive]]

Attachment: initDevices

make |_devices| init appropriately
also remove the redundant |TCPPresentationServer.close|

Comment 7

[Junior [inactive]]

try result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b684522bf317

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f66a1197daa7

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f66a1197daa7

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f66a1197daa7