Rocketbar should blur the input manually

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

With bug 1122463 we will no longer blur the input if the submit event is default prevented, which is exactly what 

https://github.com/mozilla-b2g/gaia/blob/01938468cf518009e08262532c6dfc56b6cb2210/apps/system/js/rocketbar.js#L582-L583

did. Fortunately this behavior is protected by Gij tests so I will patch the call here for it to do |this.input.blur()| on it's own.
Created attachment 8607969 [details] [review]
[gaia] timdream:rocketbar-blur > mozilla-b2g:master
Comment on attachment 8607969 [details] [review]
[gaia] timdream:rocketbar-blur > mozilla-b2g:master

Etienne,

Could you review this? Please read comment 0 for the context.
Attachment #8607969 - Flags: review?(etienne)
Comment on attachment 8607969 [details] [review]
[gaia] timdream:rocketbar-blur > mozilla-b2g:master

glad this was covered :)
Attachment #8607969 - Flags: review?(etienne) → review+
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.