Closed
Bug 1166672
Opened 9 years ago
Closed 9 years ago
Make about:telemetry work properly for optional ping sections
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
Details
(Whiteboard: [uplift])
Attachments
(1 file)
7.59 KB,
patch
|
rvitillo
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
about:telemetry rendering breaks when some optional ping sections are not present
Assignee | ||
Comment 1•9 years ago
|
||
This fixes about:telemetry rendering for sections that are not always present, e.g. when extended Telemetry recording is disabled.
Attachment #8608048 -
Flags: review?(rvitillo)
Updated•9 years ago
|
Attachment #8608048 -
Flags: review?(rvitillo) → review+
https://hg.mozilla.org/mozilla-central/rev/741dd5d30b49
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Updated•9 years ago
|
status-firefox40:
--- → affected
Whiteboard: [uplift]
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8608048 [details] [diff] [review] Make about:telemetry work properly for optional ping sections Approval Request Comment [Feature/regressing bug #]: Unified Telemetry, https://wiki.mozilla.org/Unified_Telemetry This is part of the first (main) batch of uplifts to 40 to enable shipping on that train, see bug 1120356, comment 2. [User impact if declined]: Data & measurement insight projects delayed or blocked with direct impact on projects depending on this. [Describe test coverage new/current, TreeHerder]: We have good automation coverage of the feature. We also had manual tests of the main tasks as well as confirmation of correct behavior on Nightly for the patches here. [Risks and why]: Low-risk - these patches are rather isolated to Telemetry and have been on Nightly for a while with no bad reports. We intend to track on-going data quality and other issues during the 40 aurora & beta and flip the new behavior off when it doesn't meet the requirements. [String/UUID change made/needed]: The only string changes were to the about:telemetry page. We decided that we can live with missing translations on that page for a cycle as that page is not exactly user-facing.
Attachment #8608048 -
Flags: approval-mozilla-aurora?
Comment 5•9 years ago
|
||
Comment on attachment 8608048 [details] [diff] [review] Make about:telemetry work properly for optional ping sections Unified telemetry is an important new feature. It is blocking some other projects. Taking it.
Attachment #8608048 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/bf57d61e70fe
You need to log in
before you can comment on or make changes to this bug.
Description
•