[Stingray][Dashboard] Embed weather widget into dashboard

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rexboy, Assigned: rexboy)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(2 attachments)

Embed weather widget into dashboard.
1. Open permission for dashboard that is required to embed widget.
2. Set dashboard as in-process app since the layered OOP hasn't complete yet.
3. We may need some modules/managers for managing widget in dashboard.
4. Dashboard also need to tell its widget whether it is expanded or not. Maybe through hash or IAC or something. But this can be solved in another bug.
Assignee: nobody → rexboy
Depends on: 1167058
Depends on: 1167063
Created attachment 8609307 [details] [review]
[gaia] rexboy7:1166684-embed-weather-widget > mozilla-b2g:master
Created attachment 8609309 [details] [review]
Patch

John and Yifan may you review this patch? Thanks!
Attachment #8609309 - Flags: review?(yliao)
Attachment #8609309 - Flags: review?(im)
Comment on attachment 8609309 [details] [review]
Patch

Cool! Looks good to me. Let's keep it as simple as possible.
Attachment #8609309 - Flags: review?(im) → review+
Comment on attachment 8609309 [details] [review]
Patch

Thanks! r+ with a newline missing.
Attachment #8609309 - Flags: review?(yliao) → review+
Thank you guys!

master
https://github.com/mozilla-b2g/gaia/commit/bf4453575705e1fd37d1e18eac7f16b4957b0d63
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.