Closed Bug 1166745 Opened 7 years ago Closed 7 years ago

Nightly builds running on b2g-inbound

Categories

(Taskcluster :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wcosta, Assigned: wcosta)

References

Details

Attachments

(1 file, 2 obsolete files)

As b2g-inbound job flags inherit from mozilla-central, we are running nightly builds on b2g-inbound, wasting instance resources.
Attached file MozReview Request: bz://1166745/wcosta (obsolete) —
/r/9123 - Bug 1166745: Disable nightly tasks in b2g-inbound.

Pull down this commit:

hg pull -r 96bf34d76b1a477fc14cc072c92ae6f3ab18c71a https://reviewboard-hg.mozilla.org/gecko/
Attachment #8608144 - Flags: review?(garndt)
Comment on attachment 8608144 [details]
MozReview Request: bz://1166745/wcosta

https://reviewboard.mozilla.org/r/9121/#review7777

::: testing/taskcluster/tasks/branches/b2g-inbound/job_flags.yml:101
(Diff revision 1)
> +  gaia-ui-test-functional:

This also appears below (for the test suite that was originally part of b2g-inbound's job flags list)

::: testing/taskcluster/tasks/branches/b2g-inbound/job_flags.yml:107
(Diff revision 1)
> +  gaia-ui-test-unit:

This also appears below (for the test suite that was originally part of b2g-inbound's job flags list)
Attachment #8608144 - Flags: review?(garndt)
Comment on attachment 8608144 [details]
MozReview Request: bz://1166745/wcosta

r+ as long as the gaia-ui-test-functional and gaia-ui-test-unit tests get combined.  Because they existed in b2g-i prior to merging the m-c tasks in, you have them twice and only the second ones get scheduled.

Please fix, and push to try.
Attachment #8608144 - Flags: review+
sorry, not try, push a graph to TC :)
(In reply to Greg Arndt [:garndt] from comment #3)
> Comment on attachment 8608144 [details]
> MozReview Request: bz://1166745/wcosta
> 
> https://reviewboard.mozilla.org/r/9121/#review7777
> 
> ::: testing/taskcluster/tasks/branches/b2g-inbound/job_flags.yml:101
> (Diff revision 1)
> > +  gaia-ui-test-functional:
> 
> This also appears below (for the test suite that was originally part of
> b2g-inbound's job flags list)
> 
> ::: testing/taskcluster/tasks/branches/b2g-inbound/job_flags.yml:107
> (Diff revision 1)
> > +  gaia-ui-test-unit:
> 
> This also appears below (for the test suite that was originally part of
> b2g-inbound's job flags list)

ok, fixed.
Comment on attachment 8608144 [details]
MozReview Request: bz://1166745/wcosta

/r/9123 - Bug 1166745: Disable nightly tasks in b2g-inbound.

Pull down this commit:

hg pull -r d75ce667a5c368704dd1deda3548d459faccdc29 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8608144 - Flags: review+ → review?(garndt)
Comment on attachment 8608144 [details]
MozReview Request: bz://1166745/wcosta

/r/9123 - Bug 1166745: Disable nightly tasks in b2g-inbound.

Pull down this commit:

hg pull -r 183d190a3500e56350269bca06851e9583ccf71c https://reviewboard-hg.mozilla.org/gecko/
Attachment #8608144 - Flags: review?(garndt) → review+
Comment on attachment 8608144 [details]
MozReview Request: bz://1166745/wcosta

https://reviewboard.mozilla.org/r/9121/#review7905

Ship It!
https://hg.mozilla.org/mozilla-central/rev/04cb8c5a3270
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
See Also: → 1168910
https://hg.mozilla.org/mozilla-central/rev/328baf667e38
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla41 → ---
Bug 1166745: Reorganize tasks.

- Rename nightly -> ota.
- Rename lightsaber -> spark.
- Add flame kk debug tasks.
- Add aries build tasks in treeherder.
- Add aries to try.
- Add fx-team and inbound tasks.
- Only run OTA build on m-c.
Attachment #8612325 - Flags: review?(jlal)
Attachment #8612325 - Flags: review?(garndt)
Blocks: 1164212
Comment on attachment 8612325 [details]
MozReview Request: Bug 1166745: Avoid name clashes in taskcluster index.

Hrm, it looks like I was reviewing an obsolete one on the other bug.  I'm copying/pasting my comments here.  I'm curious about the inbound job flags vs base job flags.


::: testing/taskcluster/scripts/phone-builder/build-spark-ota.sh:1
(Diff revision 1)
> +#!/bin/bash -vex

So it looks like this script does very similar things as build-phone-ota.sh except for a different mozharness config.  Perhaps in the future we could look at what dustin and morgan are doing with supplying the configs as ENV variables and then constructing them when running mozharness.

https://dxr.mozilla.org/mozilla-central/source/testing/docker/desktop-build/bin/build.sh#128

::: testing/taskcluster/tasks/branches/inbound/job_flags.yml:1
(Diff revision 1)
> +---

What will this file be used for? Looks like it was added but not used for anything and it just inherits from base_jobs.yml like everything else.

::: testing/taskcluster/tasks/branches/base_jobs.yml:1
(Diff revision 1)
> +---

Perhaps we want to update the mach stuff to default to use base_jobs.yml instead of mozilla-central/job_flags.yml when no project is given or recognized.

::: testing/taskcluster/tasks/builds/b2g_flame_kk_ota_debug.yml:9
(Diff revision 1)
> +  workerType: balrog

This could be removed, it's in the base yml
Attachment #8612325 - Flags: review?(garndt) → review+
Comment on attachment 8612325 [details]
MozReview Request: Bug 1166745: Avoid name clashes in taskcluster index.

https://reviewboard.mozilla.org/r/9123/#review8345

Ship It!
Attachment #8612325 - Flags: review?(jlal) → review+
(In reply to Greg Arndt [:garndt] from comment #17)
> Comment on attachment 8612325 [details]
> MozReview Request: Bug 1166745: Reorganize tasks.
> 
> Hrm, it looks like I was reviewing an obsolete one on the other bug.  I'm
> copying/pasting my comments here.  I'm curious about the inbound job flags
> vs base job flags.
> 
> 
> ::: testing/taskcluster/scripts/phone-builder/build-spark-ota.sh:1
> (Diff revision 1)
> > +#!/bin/bash -vex
> 
> So it looks like this script does very similar things as build-phone-ota.sh
> except for a different mozharness config.  Perhaps in the future we could
> look at what dustin and morgan are doing with supplying the configs as ENV
> variables and then constructing them when running mozharness.
> 
> https://dxr.mozilla.org/mozilla-central/source/testing/docker/desktop-build/
> bin/build.sh#128
> 

This is being worked out in bug 1164194.

> ::: testing/taskcluster/tasks/branches/inbound/job_flags.yml:1
> (Diff revision 1)
> > +---
> 
> What will this file be used for? Looks like it was added but not used for
> anything and it just inherits from base_jobs.yml like everything else.
> 

While working on it, I just didn't stop to think if it's worth merging it into base_jobs.yml.

> ::: testing/taskcluster/tasks/branches/base_jobs.yml:1
> (Diff revision 1)
> > +---
> 
> Perhaps we want to update the mach stuff to default to use base_jobs.yml
> instead of mozilla-central/job_flags.yml when no project is given or
> recognized.
> 
> ::: testing/taskcluster/tasks/builds/b2g_flame_kk_ota_debug.yml:9
> (Diff revision 1)
> > +  workerType: balrog
> 
> This could be removed, it's in the base yml

Ok.
Attachment #8612325 - Flags: review?(garndt)
Attachment #8612325 - Flags: review+
Comment on attachment 8612325 [details]
MozReview Request: Bug 1166745: Avoid name clashes in taskcluster index.

Bug 1166745: Reorganize tasks.

- Rename nightly -> ota.
- Rename lightsaber -> spark.
- Add flame kk debug tasks.
- Add aries build tasks in treeherder.
- Add aries to try.
- Add fx-team and inbound tasks.
- Only run OTA build on m-c.
Attachment #8612325 - Flags: review?(garndt) → review+
Comment on attachment 8612325 [details]
MozReview Request: Bug 1166745: Avoid name clashes in taskcluster index.

https://reviewboard.mozilla.org/r/9123/#review8353

Ship It!
Comment on attachment 8612325 [details]
MozReview Request: Bug 1166745: Avoid name clashes in taskcluster index.

Bug 1166745: Reorganize tasks.

- Rename nightly -> ota.
- Rename lightsaber -> spark.
- Add flame kk debug tasks.
- Add aries build tasks in treeherder.
- Add aries to try.
- Add fx-team and inbound tasks.
- Only run OTA build on m-c.
Attachment #8612325 - Flags: review+ → review?(garndt)
Comment on attachment 8612325 [details]
MozReview Request: Bug 1166745: Avoid name clashes in taskcluster index.

https://reviewboard.mozilla.org/r/9123/#review8359

Ship It!
Attachment #8612325 - Flags: review?(garndt) → review+
Attachment #8612325 - Attachment description: MozReview Request: Bug 1166745: Reorganize tasks. → MozReview Request: Bug 1166745: Avoid name clashes in taskcluster index.
Attachment #8612325 - Flags: review+ → review?(jlal)
Comment on attachment 8612325 [details]
MozReview Request: Bug 1166745: Avoid name clashes in taskcluster index.

Bug 1166745: Avoid name clashes in taskcluster index.

Call ota builds <phone>-ota to avoid name clashes with non-ota builds.
https://hg.mozilla.org/mozilla-central/rev/8c405367bfc6
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Attachment #8612325 - Attachment is obsolete: true
Attachment #8612325 - Flags: review?(jlal)
Attachment #8608144 - Attachment is obsolete: true
Attachment #8620337 - Flags: review+
Component: TaskCluster → General
Product: Testing → Taskcluster
Version: unspecified → Trunk
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.