Merging the final update message should take pinned status of the closed tab into account

RESOLVED FIXED in Firefox 41

Status

()

Firefox
Session Restore
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
TabState.copyFromCache(tab) is called with tab being a plain object = {linkedBrowser: browser}. The function checks tab.pinned and that being false might omit some data we would otherwise store for pinned tabs.
(Assignee)

Comment 1

3 years ago
Created attachment 8608151 [details] [diff] [review]
0001-Bug-1166763-Take-pinned-status-of-the-closed-tab-int.patch
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8608151 - Flags: review?(wmccloskey)
Comment on attachment 8608151 [details] [diff] [review]
0001-Bug-1166763-Take-pinned-status-of-the-closed-tab-int.patch

Review of attachment 8608151 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/TabState.jsm
@@ +232,2 @@
>     *
> +   * @param tab (xul:browser)

Need to change the parameter name.
Attachment #8608151 - Flags: review?(wmccloskey) → review+

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/2434e8134f3f
https://hg.mozilla.org/mozilla-central/rev/2434e8134f3f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41

Updated

2 years ago
Depends on: 1235368
You need to log in before you can comment on or make changes to this bug.