Closed Bug 1166763 Opened 5 years ago Closed 5 years ago

Merging the final update message should take pinned status of the closed tab into account

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(1 file)

TabState.copyFromCache(tab) is called with tab being a plain object = {linkedBrowser: browser}. The function checks tab.pinned and that being false might omit some data we would otherwise store for pinned tabs.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8608151 - Flags: review?(wmccloskey)
Comment on attachment 8608151 [details] [diff] [review]
0001-Bug-1166763-Take-pinned-status-of-the-closed-tab-int.patch

Review of attachment 8608151 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/TabState.jsm
@@ +232,2 @@
>     *
> +   * @param tab (xul:browser)

Need to change the parameter name.
Attachment #8608151 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/2434e8134f3f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Depends on: 1235368
You need to log in before you can comment on or make changes to this bug.