1166792 - Add top Japanese sites to unprefixing service whitelist (part 3)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Mike Taylor [:miketaylr]]

We received an addition of 15 domains to our top Japan list. These will require whitelisting (hopefully the last...):

http://sp.m.reuters.co.jp
http://www.atre.co.jp/s/
http://www.jtb.co.jp/smartphone/
http://www.sharp.co.jp/
http://www.biccamera.com/bc/top/CSfTop.jsp

I haven't looked at where the CSS is coming from yet.

Comment 1

[Mike Taylor [:miketaylr]]

OK, nothing too tricky with the exception of tabelog:

sp.m.reuters.co.jp
www.atre.co.jp
www.jtb.co.jp
www.shark.co.jp
www.biccamera.com

We're already whitelisting s.tabelog.com, but it turns out that's not good enough. Internal pages use what appears to be a cdn (k-img.com), e.g.,

http://image1-2.tabelog.k-img.com/stylesheets/smartphone/basic.css?1431927689

I've seen image1-1, image1-2, image1-3, and image1-4, all with things we want to unprefix.

Daniel, is it possible to add tabelog.k-img.com the IsOnBaseDomainWhitelist whitelist to catch the sub-subdomains? (even though it's not technically a base domain)? Or will it only work for k-img.com?

Comment 2

[Daniel Holbert [:dholbert]]

We should be able to add tabelog.k-img.com to the base-domain whitelist, yeah (and that should make us treat *.tabelog.k-img.com as being whitelisted).

Comment 3

[Mike Taylor [:miketaylr]]

Perfect, thanks.

Comment 4

[Mike Taylor [:miketaylr]]

Attachment: 1166792-Add-3rd-batch-of-top-.jp-sites-to-CSS-un.patch

Comment 5

[Mike Taylor [:miketaylr]]

Setting to checkin-needed. 

Note to sheriffs: Similar to Bug 1163826#c4, I've built locally with the patch and believe a try run is probably overkill.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb70215016e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7eb70215016e