Closed Bug 1166802 Opened 9 years ago Closed 9 years ago

Upload deleted history items

Categories

(Firefox for iOS :: Sync, defect)

Product:
Firefox for iOS
Component:
Sync
Platform:
All
iOS 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

Pull req.
47 bytes, text/x-github-pull-request
nalexander
: review+
Details | Review 
      No description provided.
Blocks: 1166812
N.B., after successful upload, remove the is_deleted=1 records from the DB.
Attached file Pull req. — 
Manually testing this now.
Comment on attachment 8608396 [details] [review]
Pull req.

Hand tested syncing, and a little automated test for the deletion stuff.

This PR has a bunch of miscellaneous fixes; please look at those too.

Next up: handling failures, adding indices, and triggering syncs.
Attachment #8608396 - Flags: review?(nalexander)
Comment on attachment 8608396 [details] [review]
Pull req.

Comments and nits on GH, but looks solid.
Attachment #8608396 - Flags: review?(nalexander) → review+
6dfce44
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: